-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Support default namespace on RocksDB #3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
Merged
Closed
Closed
Contributor
Author
This was referenced Mar 25, 2025
Contributor
|
@ndr-ds Can you update |
Contributor
Author
|
Ah, right. Will do |
99f0d12 to
36bb92d
Compare
afck
approved these changes
Mar 26, 2025
MathieuDutSik
approved these changes
Mar 26, 2025
36bb92d to
ad37184
Compare
4b37563 to
55b1403
Compare
Contributor
Author
ad37184 to
ab5f782
Compare
This was referenced Mar 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Motivation
Other databases support this (including dual store, which uses
RocksDB)Proposal
Add support for namespace not to be provided, and use default in that case, aligning this with other databases implementation
Test Plan
CI
Release Plan