Stop printing ChainWorkerRequest #3618
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 21, 2025
afck
approved these changes
Mar 21, 2025
Merged
ndr-ds
changed the base branch from
03-21-small_changes_to_benchmark
to
graphite-base/3618
ndr-ds
force-pushed
the
03-21-stop_printing_chainworkerrequest
branch
from
56c670c to
2a62775
Compare
ndr-ds
force-pushed
the
graphite-base/3618
branch
from
ab3ffda to
8300d64
Compare
Contributor
Author
This was referenced Mar 24, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
ChainWorkerRequestis huge, we shouldn't print it. Saw it on the logs, and was taking over them completely.Proposal
Stop logging the contents of
ChainWorkerRequest.Test Plan
CI + don't see it in logs anymore
Release Plan