Increase value cache size #3619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 21, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
ndr-ds
changed the base branch from
03-21-stop_printing_chainworkerrequest
to
graphite-base/3619
ndr-ds
force-pushed
the
graphite-base/3619
branch
from
56c670c to
ef947b2
Compare
ndr-ds
force-pushed
the
03-21-increase_value_cache_size
branch
from
28f058a to
38d9b1c
Compare
ndr-ds
changed the base branch from
graphite-base/3619
to
03-21-small_changes_to_benchmark
ndr-ds
changed the base branch from
03-21-small_changes_to_benchmark
to
graphite-base/3619
ndr-ds
force-pushed
the
03-21-increase_value_cache_size
branch
from
38d9b1c to
4c162f9
Compare
ndr-ds
changed the base branch from
graphite-base/3619
to
03-21-further_tune_rocksdb_options
ma2bd
approved these changes
Mar 21, 2025
Contributor
Author
ndr-ds
changed the base branch from
03-21-further_tune_rocksdb_options
to
graphite-base/3619
ndr-ds
force-pushed
the
03-21-increase_value_cache_size
branch
from
4c162f9 to
0c83e2a
Compare
This was referenced Mar 24, 2025
Closed
Closed
This was referenced Mar 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a bit of a workaround to some of the inefficiencies we see on ScyllaDB, but also doesn't hurt to have a slightly bigger cache, as the hit rate of it seems to be pretty good.
Proposal
Increase value cache size
Test Plan
CI + deployed a few networks with this
Release Plan