Skip to content

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Mar 27, 2025

Motivation

When you have a lot of chains, some of them might start sending requests before all tasks have started. This can cause the last tasks to struggle getting scheduled.

Proposal

Synchronizing before starting should fix that

Test Plan

Will test on the benchmarks

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 20babe4 to 26af26d Compare March 27, 2025 21:31
@ndr-ds ndr-ds force-pushed the 03-24-_test_use_dual_store_in_deployment branch 2 times, most recently from 4b4c106 to 468aed5 Compare March 28, 2025 14:05
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 26af26d to 932702b Compare March 28, 2025 14:05
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 932702b to e613fdb Compare April 8, 2025 15:14
@ndr-ds ndr-ds force-pushed the 03-24-_test_use_dual_store_in_deployment branch from 468aed5 to c9ff267 Compare April 8, 2025 15:14
@ndr-ds ndr-ds changed the base branch from 03-24-_test_use_dual_store_in_deployment to graphite-base/3676 April 8, 2025 16:58
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from e613fdb to d9ef4ef Compare April 8, 2025 16:58
@ndr-ds ndr-ds force-pushed the graphite-base/3676 branch from c9ff267 to dfa3e44 Compare April 8, 2025 16:58
@ndr-ds ndr-ds changed the base branch from graphite-base/3676 to 03-26-add_max_blocking_threads_option_to_client April 8, 2025 16:58
@ndr-ds ndr-ds force-pushed the 03-26-add_max_blocking_threads_option_to_client branch from dfa3e44 to 28e5a78 Compare April 8, 2025 17:16
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from d9ef4ef to 538e084 Compare April 8, 2025 17:16
@ndr-ds ndr-ds marked this pull request as ready for review April 8, 2025 17:50
@ndr-ds ndr-ds requested review from Twey, afck, christos-h, jvff and ma2bd April 8, 2025 17:50
@ndr-ds ndr-ds force-pushed the 03-26-add_max_blocking_threads_option_to_client branch from 28e5a78 to deb4e5d Compare April 8, 2025 22:40
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 538e084 to a8c7917 Compare April 8, 2025 22:40
@deuszx
Copy link
Contributor

deuszx commented Apr 9, 2025

Would an alternative approach be to prepare benchmarks on a single thread while running benchmark tasks on separate threads? That way the preparation part is not being starved.

@ndr-ds ndr-ds force-pushed the 03-26-add_max_blocking_threads_option_to_client branch from deb4e5d to f670002 Compare April 9, 2025 20:45
@ndr-ds ndr-ds force-pushed the 03-26-add_max_blocking_threads_option_to_client branch 2 times, most recently from 0cb0a47 to 6da0c79 Compare April 10, 2025 13:55
@ndr-ds ndr-ds changed the base branch from 03-26-add_max_blocking_threads_option_to_client to graphite-base/3676 April 10, 2025 19:42
Copy link
Contributor Author

ndr-ds commented Apr 10, 2025

@deuszx Depending on how many benchmark tasks are running, since they're blocking tasks, even if the prepare benchmarks is a single thread, that thread might still struggle to get scheduled to run in the same way :/
And doing the preparation single threaded will also make it slower

@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 344a842 to 4029c25 Compare April 10, 2025 19:49
@ndr-ds ndr-ds force-pushed the graphite-base/3676 branch from 6da0c79 to a46ed82 Compare April 10, 2025 19:49
@ndr-ds ndr-ds changed the base branch from graphite-base/3676 to 03-26-add_max_blocking_threads_option_to_client April 10, 2025 19:49
@ndr-ds ndr-ds force-pushed the 03-26-add_max_blocking_threads_option_to_client branch from a46ed82 to da4a06d Compare April 11, 2025 16:49
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 4029c25 to 87a1499 Compare April 11, 2025 16:49
This was referenced Apr 11, 2025
Copy link
Contributor Author

ndr-ds commented Apr 11, 2025

Merge activity

  • Apr 11, 4:39 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 11, 4:41 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 11, 4:42 PM EDT: A user merged this pull request with Graphite.

@ndr-ds ndr-ds changed the base branch from 03-26-add_max_blocking_threads_option_to_client to graphite-base/3676 April 11, 2025 20:39
@ndr-ds ndr-ds changed the base branch from graphite-base/3676 to main April 11, 2025 20:39
@ndr-ds ndr-ds force-pushed the 03-27-all_tasks_wait_before_starting branch from 87a1499 to 05a1ca6 Compare April 11, 2025 20:40
@ndr-ds ndr-ds merged commit 79daec3 into main Apr 11, 2025
25 checks passed
@ndr-ds ndr-ds deleted the 03-27-all_tasks_wait_before_starting branch April 11, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants