Remove ALLOW FILTERING usage #3771
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2025
Closed
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 14, 2025
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
4c88f1a to
986934c
Compare
ndr-ds
force-pushed
the
04-14-use_newer_scylladb_versions
branch
from
2923891 to
660ebca
Compare
ndr-ds
changed the base branch from
04-14-use_newer_scylladb_versions
to
graphite-base/3771
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
986934c to
8cd10f5
Compare
ndr-ds
force-pushed
the
graphite-base/3771
branch
from
660ebca to
30d8d29
Compare
ndr-ds
changed the base branch from
graphite-base/3771
to
04-14-use_newer_scylladb_chart_versions
This was referenced Apr 16, 2025
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
8cd10f5 to
107c007
Compare
ndr-ds
force-pushed
the
04-14-use_newer_scylladb_chart_versions
branch
from
30d8d29 to
d738461
Compare
ndr-ds
changed the base branch from
04-14-use_newer_scylladb_chart_versions
to
graphite-base/3771
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
107c007 to
eff7479
Compare
ndr-ds
changed the base branch from
graphite-base/3771
to
04-14-use_newer_scylla_driver_crate_version
ndr-ds
changed the base branch from
04-14-use_newer_scylla_driver_crate_version
to
graphite-base/3771
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
eff7479 to
48861e8
Compare
ndr-ds
changed the base branch from
graphite-base/3771
to
04-16-update_versions_inside_scylla-manager_config
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
48861e8 to
d8fe153
Compare
ndr-ds
force-pushed
the
04-16-update_versions_inside_scylla-manager_config
branch
2 times, most recently
from
eadb010 to
a2b1039
Compare
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
d8fe153 to
dc587a4
Compare
ndr-ds
force-pushed
the
04-14-remove_allow_filtering_usage
branch
from
dc587a4 to
d5cf801
Compare
ndr-ds
changed the base branch from
04-16-update_versions_inside_scylla-manager_config
to
graphite-base/3771
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ALLOW_FILTERINGis something that is heavily advised against in the ScyllaDB docs, as it tends to cause big performance regressions.Proposal
Remove
ALLOW_FILTERINGusage.Test Plan
CI + will deploy a network with this
Release Plan