Skip to content

Use enum for BuildMode #3753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2025
Merged

Use enum for BuildMode #3753

merged 1 commit into from
Apr 12, 2025
+35 −13

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Apr 11, 2025

Motivation

This was a comment in the original PR, forgot to address before merging

Proposal

Address comment and use enum

Test Plan

CI

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

This was referenced Apr 11, 2025
Closed
Merged
Merged
Merged
Merged
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Apr 11, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

ma2bd
ma2bd approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@ma2bd ma2bd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ndr-ds ndr-ds force-pushed the 04-11-use_enum_for_buildmode branch from cc9bed1 to 47d73eb Compare April 11, 2025 20:42
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from c940ad5 to 94539ed Compare April 11, 2025 20:42
@ndr-ds ndr-ds changed the base branch from 04-09-increase_upper_bound_for_inbox_size_metric to graphite-base/3753 April 11, 2025 20:44
@ndr-ds ndr-ds force-pushed the 04-11-use_enum_for_buildmode branch from 47d73eb to a607391 Compare April 11, 2025 20:48
@ndr-ds ndr-ds force-pushed the graphite-base/3753 branch from 94539ed to fa8dbac Compare April 11, 2025 20:48
@graphite-app graphite-app bot changed the base branch from graphite-base/3753 to main April 11, 2025 20:48
@ndr-ds ndr-ds force-pushed the 04-11-use_enum_for_buildmode branch from a607391 to c1dc77d Compare April 11, 2025 20:48
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Apr 12, 2025 •
edited
Loading

Merge activity

  • Apr 11, 10:23 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 11, 10:24 PM EDT: A user merged this pull request with Graphite.

@ndr-ds ndr-ds merged commit b928691 into main Apr 12, 2025
25 checks passed
@ndr-ds ndr-ds deleted the 04-11-use_enum_for_buildmode branch April 12, 2025 02:24
This was referenced Apr 14, 2025
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ma2bd ma2bd ma2bd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndr-ds @ma2bd