Skip to content

Increase upper bound for inbox size metric #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Increase upper bound for inbox size metric #3742

merged 1 commit into from
Apr 11, 2025

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Apr 9, 2025

Motivation

I've seen inbox size p99 reach half a million during benchmarks

Proposal

Bump it to 2 million

Test Plan

Will deploy a network with this

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

This was referenced Apr 9, 2025
Closed
Merged
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Apr 9, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ndr-ds ndr-ds mentioned this pull request Apr 9, 2025
Merged
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from dd1f8e1 to 9e06304 Compare April 9, 2025 20:45
@ndr-ds ndr-ds force-pushed the 04-08-make_rocksdb_config_dependant_of_current_hardware branch from cd7e8d6 to 212506f Compare April 9, 2025 20:45
@ndr-ds ndr-ds mentioned this pull request Apr 9, 2025
Merged
@ndr-ds ndr-ds changed the base branch from 04-08-make_rocksdb_config_dependant_of_current_hardware to graphite-base/3742 April 10, 2025 19:56
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from 9e06304 to 82a3793 Compare April 10, 2025 20:00
@ndr-ds ndr-ds force-pushed the graphite-base/3742 branch from 212506f to 936230c Compare April 10, 2025 20:00
@ndr-ds ndr-ds changed the base branch from graphite-base/3742 to 04-08-make_rocksdb_config_dependant_of_current_hardware April 10, 2025 20:00
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from 82a3793 to c940ad5 Compare April 11, 2025 16:49
@ndr-ds ndr-ds force-pushed the 04-08-make_rocksdb_config_dependant_of_current_hardware branch from 936230c to 0840bd6 Compare April 11, 2025 16:49
This was referenced Apr 11, 2025
Closed
Merged
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Apr 11, 2025 •
edited
Loading

Merge activity

  • Apr 11, 4:39 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 11, 4:45 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 11, 4:46 PM EDT: A user merged this pull request with Graphite.

@ndr-ds ndr-ds force-pushed the 04-08-make_rocksdb_config_dependant_of_current_hardware branch from 0840bd6 to 5ca761a Compare April 11, 2025 20:42
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from c940ad5 to 94539ed Compare April 11, 2025 20:42
@ndr-ds ndr-ds changed the base branch from 04-08-make_rocksdb_config_dependant_of_current_hardware to graphite-base/3742 April 11, 2025 20:43
@ndr-ds ndr-ds changed the base branch from graphite-base/3742 to main April 11, 2025 20:43
@ndr-ds ndr-ds force-pushed the 04-09-increase_upper_bound_for_inbox_size_metric branch from 94539ed to b9d130e Compare April 11, 2025 20:44
@ndr-ds ndr-ds merged commit fa8dbac into main Apr 11, 2025
25 checks passed
@ndr-ds ndr-ds deleted the 04-09-increase_upper_bound_for_inbox_size_metric branch April 11, 2025 20:46
This was referenced Apr 14, 2025
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ma2bd ma2bd ma2bd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndr-ds @ma2bd