Ask confirmation to start benchmark #3744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
changed the base branch from
03-24-_test_use_dual_store_in_deployment
to
graphite-base/3744
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
386d2c3 to
e658860
Compare
ndr-ds
force-pushed
the
graphite-base/3744
branch
from
fb0888e to
9e06304
Compare
ndr-ds
changed the base branch from
graphite-base/3744
to
04-09-increase_upper_bound_for_inbox_size_metric
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
e658860 to
cb9dbad
Compare
ndr-ds
force-pushed
the
04-09-increase_upper_bound_for_inbox_size_metric
branch
2 times, most recently
from
82a3793 to
c940ad5
Compare
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
cb9dbad to
e4dfb8f
Compare
This was referenced Apr 11, 2025
Closed
Merged
ndr-ds
changed the base branch from
04-09-increase_upper_bound_for_inbox_size_metric
to
graphite-base/3744
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
e4dfb8f to
6134bd3
Compare
ndr-ds
force-pushed
the
graphite-base/3744
branch
from
c940ad5 to
fa8dbac
Compare
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
6134bd3 to
844e83e
Compare
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
844e83e to
5bbd3f0
Compare
ndr-ds
changed the base branch from
graphite-base/3744
to
04-11-use_enum_for_buildmode
ndr-ds
changed the base branch from
04-11-use_enum_for_buildmode
to
graphite-base/3744
ndr-ds
force-pushed
the
graphite-base/3744
branch
from
c1dc77d to
b928691
Compare
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
5bbd3f0 to
43b0f17
Compare
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
2 times, most recently
from
cc1fb80 to
a02a94b
Compare
This was referenced Apr 14, 2025
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
a02a94b to
b8aa240
Compare
This was referenced Apr 14, 2025
ndr-ds
force-pushed
the
04-09-ask_confirmation_to_start_benchmark
branch
from
b8aa240 to
9766da9
Compare
ma2bd
approved these changes
Apr 16, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When benchmarking, it's better to not have chain creation blocks having to be executed in the middle of the benchmark. So we might as well add a confirmation so that we can get all the processes ready, and then start them as we please.
Proposal
Add confirmation to start the benchmark, after preparing.
Test Plan
Ran this a few times already while benchmarking.
Release Plan