Skip to content

Missed one rename still using CloneWithRootKey #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Missed one rename still using CloneWithRootKey #4055

merged 1 commit into from
Jun 3, 2025

Conversation

@ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Jun 3, 2025

Motivation

When renaming clone_with_root_key to open_exclusive, one error name was missed.

Proposal

Update it to the new name

Test Plan

CI

Release Plan

  • Nothing to do / These changes follow the usual release cycle.

This was referenced Jun 3, 2025
Closed
Closed
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Jun 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ndr-ds ndr-ds requested review from Twey, afck, deuszx and ma2bd June 3, 2025 21:27
@ndr-ds ndr-ds mentioned this pull request Jun 3, 2025
Merged
@ndr-ds ndr-ds changed the base branch from 06-03-truncate_query_output_on_query_node to graphite-base/4055 June 3, 2025 21:29
@ndr-ds ndr-ds force-pushed the 06-03-missed_one_rename_still_using_clonewithrootkey branch from 293cfa7 to c383076 Compare June 3, 2025 21:29
@ndr-ds ndr-ds force-pushed the graphite-base/4055 branch from 3fb79cf to 293ab1b Compare June 3, 2025 21:29
@graphite-app graphite-app bot changed the base branch from graphite-base/4055 to main June 3, 2025 21:30
@ndr-ds ndr-ds force-pushed the 06-03-missed_one_rename_still_using_clonewithrootkey branch from c383076 to 44f8423 Compare June 3, 2025 21:30
@ndr-ds Graphite App
Copy link
Contributor Author

ndr-ds commented Jun 3, 2025 •
edited
Loading

Merge activity

  • Jun 3, 10:09 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 3, 10:10 PM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (This repository has GitHub's merge queue enabled, which is currently incompatible with Graphite).

@ndr-ds ndr-ds added this pull request to the merge queue Jun 3, 2025
Merged via the queue into main with commit 9557902 Jun 3, 2025
25 checks passed
@ndr-ds ndr-ds deleted the 06-03-missed_one_rename_still_using_clonewithrootkey branch June 3, 2025 22:47
@ndr-ds ndr-ds mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ma2bd ma2bd ma2bd approved these changes

@afck afck Awaiting requested review from afck

@deuszx deuszx Awaiting requested review from deuszx

@Twey Twey Awaiting requested review from Twey

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndr-ds @ma2bd