Improve wallet show output.
#4927
Open
+38
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
requested review from
MathieuDutSik,
Twey,
bart-linera,
deuszx,
eldios,
ma2bd and
ndr-ds
ma2bd
approved these changes
Nov 6, 2025
| Some(ChainOrigin::Root(i)) => format!("Root Chain {i}"), | ||
| _ => "Child Chain".to_string(), | ||
| println!("-----------------------"); | ||
| println!(" {:<20} {}", "Chain ID:", self.user_chain.chain_id); |
There was a problem hiding this comment.
We could almost remove the indentation if we wanted now
There was a problem hiding this comment.
Do you prefer that?
Do you mean remove the two leading spaces, or remove the alignment of the values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the result after a few discussions about what
wallet showshould look like.Proposal
Add separators between the chains. Format everything in a "Key: Value" style.
Test Plan
Sample output:
Release Plan
testnet_conway, thenLinks
wallet showchange: Improvewallet show. #4642