fix: continue-on-error at the workflow job level #10709

[mhitza]

Using the continue-on-error flag at the action level resulted in jobs showing as passed even if individual steps have failed.

• Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

• I have read the Contributing doc
• I have read the Creating and reviewing pull requests at LinkORB guide doc
• Lint and unit tests pass locally with my changes
• I have added/updated necessary documentation in the README.md or doc/ directories (if appropriate)

[Copilot]

Pull request overview

This PR fixes the issue where commit convention checks were showing as passed even when individual steps failed, by moving the continue-on-error: true flag from the step level to the job level in the review workflow. This change ensures that when the commit-conventions job fails, it displays with a warning status (yellow icon) rather than appearing as passed (green icon), providing better visibility of CI/CD pipeline failures.

Key Changes:

• Moved continue-on-error: true from individual step level to the commit-conventions job level
• Removed the step-level continue-on-error flags from both the conventional commits check and the commit message checker steps

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
templates/.github/workflows/10-review.yaml.j2	Template file: Added job-level continue-on-error: true and removed step-level instances
.github/workflows/10-review.yaml	Generated workflow file: Added job-level continue-on-error: true and removed step-level instances

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.