Skip to content

fix: continue-on-error at the workflow job level #10709 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhitza merged 1 commit into from
Nov 21, 2025
Merged

fix: continue-on-error at the workflow job level #10709 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/10-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ jobs:
runs-on: ubuntu-latest
# Don't enforce commit conventions checks for Dependabot
if: github.actor != 'dependabot[bot]'
continue-on-error: true
steps:
- uses: actions/checkout@v5

# interesting alternative: https://github.com/cocogitto/cocogitto
- uses: webiny/action-conventional-commits@v1.3.0
# XXX: normal action versioning syntax (`@v1`) doesn't work with this action,
# possibly because not published on the GitHub marketplace
continue-on-error: true

- name: Check Card# reference
uses: linkorb/commit-message-checker@v1
Expand All @@ -32,5 +32,4 @@ jobs:
excludeTitle: 'true' # optional: this excludes the title of a pull request
checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request
accessToken: ${{ secrets.GITHUB_TOKEN }} # github access token is only required if checkAllCommitMessages is true
continue-on-error: true

3 changes: 1 addition & 2 deletions templates/.github/workflows/10-review.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ jobs:
runs-on: ubuntu-latest
# Don't enforce commit conventions checks for Dependabot
if: github.actor != 'dependabot[bot]'
continue-on-error: true
steps:
- uses: actions/checkout@v5

# interesting alternative: https://github.com/cocogitto/cocogitto
- uses: webiny/action-conventional-commits@v1.3.0
# XXX: normal action versioning syntax (`@v1`) doesn't work with this action,
# possibly because not published on the GitHub marketplace
continue-on-error: true

- name: Check Card# reference
uses: linkorb/commit-message-checker@v1
Expand All @@ -32,7 +32,6 @@ jobs:
excludeTitle: 'true' # optional: this excludes the title of a pull request
checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request
accessToken: ${{ secrets.GITHUB_TOKEN }} # github access token is only required if checkAllCommitMessages is true
continue-on-error: true

{% if enable_reviewdog %}
code-quality:
Expand Down