Skip to content

fix: git clone command #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ani1357 merged 5 commits into from
Nov 13, 2024
Merged

fix: git clone command #579

Ani1357 merged 5 commits into from
Nov 13, 2024

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Nov 7, 2024

This PR fixes git clone command in repo.ts with encodeURIComponent().

@Ani1357
Copy link
Contributor

Ani1357 commented Nov 7, 2024

Tested by setting this password NewPassword123@! but unfortunately I'm getting this error:

gitea-http.gitea.svc.cluster.local:3000/otomi/values.git/
Cloning into 'values'...
warning: templates not found in /usr/share/git-core/templates
fatal: unable to access 'http://[email protected]:3000/otomi/values.git/': Could not resolve host: [email protected]

CasLubbers
CasLubbers reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me but I still get the error in the Tekton pipeline:
Screenshot 2024-11-12 at 10 43 05 AM.
I think this requires changes in core?

@Ani1357 Ani1357 mentioned this pull request Nov 12, 2024
Merged
Ani1357
Ani1357 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in conjunction with this PR and it works as expected.

@Ani1357 Ani1357 merged commit 4f80e5a into main Nov 13, 2024
@Ani1357 Ani1357 deleted the APL-356 branch November 13, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CasLubbers CasLubbers CasLubbers approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@dennisvankekem dennisvankekem Awaiting requested review from dennisvankekem dennisvankekem is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferruhcihan @Ani1357 @CasLubbers