Skip to content

fix: git clone command #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ani1357 merged 5 commits into from
Nov 13, 2024
Merged

fix: git clone command #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
262fb80
fix: git clone command in repo.ts with encodeURIComponent()
ferruhcihan Nov 7, 2024
92352a2
fix: clone charts repo
ferruhcihan Nov 7, 2024
bbf88b3
Merge branch 'main' into APL-356
Ani1357 Nov 7, 2024
7f5fb15
Merge branch 'main' into APL-356
ferruhcihan Nov 12, 2024
17ccdb1
Merge branch 'main' into APL-356
Ani1357 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/repo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ function getUrlAuth(url, user, password): string | undefined {
if (!url) return
const protocol = getProtocol(url)
const [_, bareUrl] = url.split('://')
return protocol === 'file' ? `${protocol}://${bareUrl}` : `${protocol}://${user}:${password}@${bareUrl}`
const encodedUser = encodeURIComponent(user as string)
const encodedPassword = encodeURIComponent(password as string)
return protocol === 'file' ? `${protocol}://${bareUrl}` : `${protocol}://${encodedUser}:${encodedPassword}@${bareUrl}`
}

const secretFileRegex = new RegExp(`^(.*/)?secrets.*.yaml(.dec)?$`)
Expand Down
4 changes: 3 additions & 1 deletion src/utils/workloadUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@ export async function fetchWorkloadCatalog(
let gitUrl = url
if (isGiteaURL(url)) {
const [protocol, bareUrl] = url.split('://')
gitUrl = `${protocol}://${process.env.GIT_USER}:${process.env.GIT_PASSWORD}@${bareUrl}`
const encodedUser = encodeURIComponent(process.env.GIT_USER as string)
const encodedPassword = encodeURIComponent(process.env.GIT_PASSWORD as string)
gitUrl = `${protocol}://${encodedUser}:${encodedPassword}@${bareUrl}`
}
shell.exec(`git clone --depth 1 ${gitUrl} ${helmChartsDir}`)
const files = await readdir(`${helmChartsDir}`, 'utf-8')
Expand Down