fix: logout error #584
Merged
fix: logout error #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruhcihan
requested review from
Ani1357,
ElderMatt,
dennisvankekem and
merll
dennisvankekem
approved these changes
Nov 15, 2024
Contributor
dennisvankekem
left a comment
dennisvankekem
left a comment
There was a problem hiding this comment.
LGTM, minor detail: If I create a shell and logout, but press return on the keycloak confirmation screen, then I get a 504 error, however that error goes away on reload and is maybe understandable. Afterwards I can continue creating shells, so great work!
Ani1357
approved these changes
Nov 15, 2024
Contributor
Ani1357
left a comment
Ani1357
left a comment
There was a problem hiding this comment.
Tested and it is working as expected.
Tested as a:
- team user
- team admin
- platform admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
https://jira.linode.com/browse/APL-370
Description
This PR fixes logout errors and updates delete coudtty functions
Is paired with: linode/apl-console#460