Skip to content

fix: logout error #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ferruhcihan merged 35 commits into from
Nov 15, 2024
Merged

fix: logout error #460

ferruhcihan merged 35 commits into from
Nov 15, 2024

Conversation

@ferruhcihan
Copy link
Collaborator

@ferruhcihan ferruhcihan commented Nov 15, 2024 •
edited
Loading

Implements

https://jira.linode.com/browse/APL-370

Description

This PR fixes logout errors and updates error handling.
Is paired with: linode/apl-api#584

@ferruhcihan ferruhcihan mentioned this pull request Nov 15, 2024
Merged
@dennisvankekem dennisvankekem self-assigned this Nov 15, 2024
dennisvankekem
dennisvankekem approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@dennisvankekem dennisvankekem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks clean,

Tested on cluster with Chrome, Firefox and Safari. Also tested logout cancelation and multiple browsers at the same time. For some reason I didn't get the object storage wizard pop up in Chrome, only in Firefox, but I think that's not related to this PR

Ani1357
Ani1357 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it is working as expected.
Tested as a:

team user
team admin
platform admin

@ferruhcihan
Copy link
Collaborator Author

ferruhcihan commented Nov 15, 2024

Code looks clean,

Tested on cluster with Chrome, Firefox and Safari. Also tested logout cancelation and multiple browsers at the same time. For some reason I didn't get the object storage wizard pop up in Chrome, only in Firefox, but I think that's not related to this PR

We store showObjWizard value in the browser local storage. I might be the reason.

@ferruhcihan ferruhcihan merged commit 48da38e into main Nov 15, 2024
3 checks passed
@ferruhcihan ferruhcihan deleted the APL-370 branch November 15, 2024 14:53
@dennisvankekem dennisvankekem self-assigned this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisvankekem dennisvankekem dennisvankekem approved these changes

@Ani1357 Ani1357 Ani1357 approved these changes

@merll merll Awaiting requested review from merll

@ElderMatt ElderMatt Awaiting requested review from ElderMatt

Assignees

@dennisvankekem dennisvankekem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ferruhcihan @dennisvankekem @Ani1357