Skip to content

Conversation

@dennisvankekem
Copy link
Contributor

@dennisvankekem dennisvankekem commented Mar 31, 2025

@dennisvankekem dennisvankekem marked this pull request as ready for review April 2, 2025 09:16
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
50.24% (-0.13% 🔻)
2237/4453
🔴 Branches
34.56% (-0.23% 🔻)
356/1030
🔴 Functions
42.98% (-0.16% 🔻)
413/961
🔴 Lines
50.6% (-0.11% 🔻)
2102/4154
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 authz.ts
85.98% (-2.71% 🔻)
68.42% (-4.79% 🔻)
89.74% (-2.76% 🔻)
89.29% (-2.97% 🔻)

Test suite run success

289 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 080ec30

@dennisvankekem
Copy link
Contributor Author

The proposed resourceQuota is not compatible.

  • Decorator and mutable needs to be removed from the ResourceQuota object and need to be implemented in the console
  • loadbalancers is nodeports don't have the services. in front of them
  • compute resource quotas are send as numbers but should be send in the right notation (e.g. cpu should be 500m instead of just 500)
  • enabled flag needs to be removed

To reflect this:

  • ResourceQuota data structure needs to be reverted
  • Console needs to map the keys to decorator and mutable fields
  • additions in migration for resourceQuota need to be removed
  • ResourceQuota enabled checkbox can be removed

@dennisvankekem dennisvankekem marked this pull request as draft April 10, 2025 12:38
@dennisvankekem dennisvankekem marked this pull request as ready for review April 14, 2025 14:52
@dennisvankekem dennisvankekem merged commit e4b1756 into main Apr 17, 2025
3 checks passed
@dennisvankekem dennisvankekem deleted the APL-540 branch April 17, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants