-
Notifications
You must be signed in to change notification settings - Fork 3
feat: static team settings page #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
note to self: fix light mode |
|
Ready for first pass test and review, note that some logs and type: any might be floating around still. |
|
The proposed resourceQuota is not compatible.
To reflect this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- public/i18n/en/common.json: Language not supported
Comments suppressed due to low confidence (2)
src/components/forms/TextField.tsx:335
- Using 'cleanedValue || ""' may inadvertently convert valid numeric inputs like 0 to an empty string. Consider an explicit check (e.g., checking 'cleanedValue' for null or undefined) to preserve 0 as a valid value.
setValue(cleanedValue || '')
src/components/KeyValue.tsx:186
- The TextField for the key is being assigned a static prop 'keyValue', which may override the form state managed by react-hook-form. Consider removing this prop or sourcing the value from the form state to ensure proper updates.
value={keyValue}















PRs:
console: #531
api: linode/apl-api#672
core: linode/apl-core#2024
Considerations