Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

@dennisvankekem dennisvankekem commented Mar 21, 2025

PRs:

console: #531
api: linode/apl-api#672
core: linode/apl-core#2024

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem
Copy link
Collaborator Author

note to self: fix light mode

@dennisvankekem dennisvankekem changed the title feat: team settings page rework feat: static team settings page Mar 31, 2025
@dennisvankekem dennisvankekem marked this pull request as ready for review April 2, 2025 09:12
@dennisvankekem
Copy link
Collaborator Author

Ready for first pass test and review, note that some logs and type: any might be floating around still.

@ElderMatt
Copy link
Contributor

We have to find a solution for these extreme long texts. They are not nice to read at the moment.
image
image

@ElderMatt
Copy link
Contributor

Do we want to have a error message that the field is empty?
image

@ElderMatt
Copy link
Contributor

I find the text hard to read for the values, especially for the not editable values.
image

@ElderMatt
Copy link
Contributor

Why the extra empty space between the first and second field?
image

@dennisvankekem
Copy link
Collaborator Author

Why the extra empty space between the first and second field? image

it's in the design, the design idea is to separate the url from the provider specific values

@dennisvankekem
Copy link
Collaborator Author

Do we want to have a error message that the field is empty? image

I think empty fields should be ignored, I will fix it

@dennisvankekem
Copy link
Collaborator Author

We have to find a solution for these extreme long texts. They are not nice to read at the moment. image image

I will schedule a frontend meeting this afternoon

@ferruhcihan ferruhcihan self-assigned this Apr 3, 2025
@dennisvankekem
Copy link
Collaborator Author

image

light mode also needs some adjustment

@dennisvankekem
Copy link
Collaborator Author

The proposed resourceQuota is not compatible.

  • Decorator and mutable needs to be removed from the ResourceQuota object and need to be implemented in the console
  • loadbalancers is nodeports don't have the services. in front of them
  • compute resource quotas are send as numbers but should be send in the right notation (e.g. cpu should be 500m instead of just 500)
  • enabled flag needs to be removed

To reflect this:

  • ResourceQuota data structure needs to be reverted
  • Console needs to map the keys to decorator and mutable fields
  • additions in migration for resourceQuota need to be removed
  • ResourceQuota enabled checkbox can be removed

@dennisvankekem dennisvankekem marked this pull request as draft April 10, 2025 12:38
@dennisvankekem dennisvankekem marked this pull request as ready for review April 14, 2025 14:52
@dennisvankekem dennisvankekem requested a review from Copilot April 15, 2025 07:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • public/i18n/en/common.json: Language not supported
Comments suppressed due to low confidence (2)

src/components/forms/TextField.tsx:335

  • Using 'cleanedValue || ""' may inadvertently convert valid numeric inputs like 0 to an empty string. Consider an explicit check (e.g., checking 'cleanedValue' for null or undefined) to preserve 0 as a valid value.
setValue(cleanedValue || '')

src/components/KeyValue.tsx:186

  • The TextField for the key is being assigned a static prop 'keyValue', which may override the form state managed by react-hook-form. Consider removing this prop or sourcing the value from the form state to ensure proper updates.
value={keyValue}

@ElderMatt
Copy link
Contributor

ElderMatt commented Apr 16, 2025

When I run npm run gen-store I get changes in the otomiApi.ts

image

@ElderMatt
Copy link
Contributor

Too much empty space between Alerts and checkbox
image

@ElderMatt
Copy link
Contributor

When a quota array is empty the label should be removed. The label text is also gray instead of white.
image

@ElderMatt
Copy link
Contributor

Column label Action and Team Members should be a larger font. Currently they are same font-size as row text.
image

@ElderMatt
Copy link
Contributor

Light mode needs some attention, I think changing all the light gray text to black should fix it.
image

@dennisvankekem dennisvankekem merged commit 14f08b2 into main Apr 17, 2025
2 checks passed
@dennisvankekem dennisvankekem deleted the APL-540 branch April 17, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants