-
Notifications
You must be signed in to change notification settings - Fork 3
feat: service page using form components #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dennisvankekem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass, UI test will follow later
dennisvankekem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first ui pass, please see comments
|
traffic management still has the 50/50 default bug
|
ferruhcihan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Thursday, we worked together with @ElderMatt and @dennisvankekem and tested it, but we weren’t able to expose the services consistently.
Aside from that, the code looks good. The new components are functioning as expected, so it’s LGTM from my side.
dennisvankekem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done, this was a hard one




Also see the other PRs:
Considerations