Skip to content

Conversation

@ElderMatt
Copy link
Contributor

@ElderMatt ElderMatt commented Mar 12, 2025

Also see other PRs:

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@github-actions
Copy link

github-actions bot commented Mar 12, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
49.07% (+0.45% 🔼)
1061/2162
🔴 Branches
33.13% (+0.89% 🔼)
212/640
🔴 Functions
40.67% (+1.14% 🔼)
122/300
🔴 Lines
48.4% (+0.48% 🔼)
938/1938

Test suite run success

92 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 7355487

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts due to the APL-502 changes. Other than that, LGTM.

@ElderMatt ElderMatt requested a review from j-zimnowoda April 17, 2025 07:27
@ElderMatt ElderMatt requested a review from merll April 23, 2025 13:06
@ElderMatt ElderMatt dismissed j-zimnowoda’s stale review April 23, 2025 13:06

have been removed

Copy link
Contributor

@merll merll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion, otherwise looks good.

@ElderMatt ElderMatt merged commit f3b5745 into main Apr 23, 2025
7 checks passed
@ElderMatt ElderMatt deleted the APL-537 branch April 23, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants