-
Notifications
You must be signed in to change notification settings - Fork 180
feat: service page using new components #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Test suite run success92 tests passing in 9 suites. Report generated by 🧪jest coverage report action from 7355487 |
ferruhcihan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts due to the APL-502 changes. Other than that, LGTM.
merll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion, otherwise looks good.
Co-authored-by: merll <[email protected]>
Also see other PRs:
Checklist
adr/*.mdand appended to list inadr/_index.md, if applicable.values-schema.yamlfile andtest/**fixtures have been updated to reflect code changes, if applicable.values-schema.yamlfile, if applicable.