Skip to content

Conversation

@merll
Copy link
Contributor

@merll merll commented Jan 29, 2026

📌 Summary

This PR enhances the functionality by responding to creation of Kubernetes manifest files in specific directories of the values repository. Files created in env/manifests/ns// result in creation of an ArgoCD application that creates and deploys everything into the namespace with the directory name. Manifest files stored in env/manifest/global/ are intended for cluster-wide objects and therefore do not imply a target namespace, and do not create any.
Removing any of the namespace directories removes the ArgoCD application as well. Removing all manifests from global does not remove the ArgoCD application, due to risks arising from deleting cluster-wide objects.

In order to avoid unintended changes to unrelated ArgoCD applications, labels are added and used for selection. The platform app updates have been extended accordingly.

🔍 Reviewer Notes

Verifying that the namespace matches the directory name has been out of scope of the defined functionality, therefore the manifest can override the target deployment namespace. Additional functionality is planned to be implemented in the API.

🧹 Checklist

  • Code is readable, maintainable, and robust.
  • Unit tests added/updated

@linode linode deleted a comment from svcAPLBot Jan 29, 2026
@merll merll marked this pull request as draft January 29, 2026 12:45
@linode linode deleted a comment from svcAPLBot Jan 29, 2026
@merll merll marked this pull request as ready for review January 29, 2026 13:13
@linode linode deleted a comment from svcAPLBot Jan 29, 2026
@linode linode deleted a comment from svcAPLBot Jan 29, 2026
Copy link
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on cluster.
Created two directories
${ENV_DIR}/
└── env/
└── manifests/
├── global/
│ └── test-configmap.yaml
└── ns/
└── team-demo/
└── configmap.yaml
Both got created. Afterwards deleted them the gitops-global app was still there and the team-demo one got deleted with its resources. ✅
Only one comment about making the applyGitOpsApps more readable. The rest looks good to me

@svcAPLBot
Copy link
Contributor

Comparison of Helm chart templating output:

@@ spec.ingress @@
! + one list entry added:
+ - from:
+   - namespaceSelector:
+       matchLabels:
+         name: argocd
+     podSelector:
+       matchLabels:
+         app.kubernetes.io/name: argocd-repo-server


@@ (root level) @@
! + one document added:
+ ---
+ # Source: raw/templates/resources.yaml
+ apiVersion: v1
+ data:
+   url: aHR0cDovL2dpdGVhLWh0dHAuZ2l0ZWEuc3ZjLmNsdXN0ZXIubG9jYWw6MzAwMC9vdG9taS92YWx1ZXMuZ2l0
+   password: Z2l0ZWFBZG1pblBhc3N3b3Jk
+   type: Z2l0
+   username: b3RvbWktYWRtaW4=
+ kind: Secret
+ metadata:
+   name: argocd-repo-creds-gitea-internal
+   namespace: argocd
+   labels:
+     app: raw
+     app.kubernetes.io/instance: argocd-artifacts
+     app.kubernetes.io/managed-by: Helm
+     app.kubernetes.io/name: raw
+     app.kubernetes.io/part-of: otomi
+     app.kubernetes.io/version: 0.2.3
+     argocd.argoproj.io/secret-type: repo-creds
+     helm.sh/chart: raw-0.2.3



@@ metadata @@
! + one map entry added:
+ labels:
+   otomi.io/app: team-gitops


@@ metadata @@
! + one map entry added:
+ labels:
+   otomi.io/app: team-gitops


@@ metadata @@
! + one map entry added:
+ labels:
+   otomi.io/app: team-gitops

@linode linode deleted a comment from svcAPLBot Jan 30, 2026
@merll merll merged commit 0a3cf8d into main Jan 30, 2026
15 checks passed
@merll merll deleted the APL-1420-rebase branch January 30, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants