-
Notifications
You must be signed in to change notification settings - Fork 180
feat: custom kubernetes manifest in the values repo #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CasLubbers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on cluster.
Created two directories
${ENV_DIR}/
└── env/
└── manifests/
├── global/
│ └── test-configmap.yaml
└── ns/
└── team-demo/
└── configmap.yaml
Both got created. Afterwards deleted them the gitops-global app was still there and the team-demo one got deleted with its resources. ✅
Only one comment about making the applyGitOpsApps more readable. The rest looks good to me
|
Comparison of Helm chart templating output: @@ spec.ingress @@
! + one list entry added:
+ - from:
+ - namespaceSelector:
+ matchLabels:
+ name: argocd
+ podSelector:
+ matchLabels:
+ app.kubernetes.io/name: argocd-repo-server
@@ (root level) @@
! + one document added:
+ ---
+ # Source: raw/templates/resources.yaml
+ apiVersion: v1
+ data:
+ url: aHR0cDovL2dpdGVhLWh0dHAuZ2l0ZWEuc3ZjLmNsdXN0ZXIubG9jYWw6MzAwMC9vdG9taS92YWx1ZXMuZ2l0
+ password: Z2l0ZWFBZG1pblBhc3N3b3Jk
+ type: Z2l0
+ username: b3RvbWktYWRtaW4=
+ kind: Secret
+ metadata:
+ name: argocd-repo-creds-gitea-internal
+ namespace: argocd
+ labels:
+ app: raw
+ app.kubernetes.io/instance: argocd-artifacts
+ app.kubernetes.io/managed-by: Helm
+ app.kubernetes.io/name: raw
+ app.kubernetes.io/part-of: otomi
+ app.kubernetes.io/version: 0.2.3
+ argocd.argoproj.io/secret-type: repo-creds
+ helm.sh/chart: raw-0.2.3
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops
@@ metadata @@
! + one map entry added:
+ labels:
+ otomi.io/app: team-gitops |
📌 Summary
This PR enhances the functionality by responding to creation of Kubernetes manifest files in specific directories of the values repository. Files created in env/manifests/ns// result in creation of an ArgoCD application that creates and deploys everything into the namespace with the directory name. Manifest files stored in env/manifest/global/ are intended for cluster-wide objects and therefore do not imply a target namespace, and do not create any.
Removing any of the namespace directories removes the ArgoCD application as well. Removing all manifests from global does not remove the ArgoCD application, due to risks arising from deleting cluster-wide objects.
In order to avoid unintended changes to unrelated ArgoCD applications, labels are added and used for selection. The platform app updates have been extended accordingly.
🔍 Reviewer Notes
Verifying that the namespace matches the directory name has been out of scope of the defined functionality, therefore the manifest can override the target deployment namespace. Additional functionality is planned to be implemented in the API.
🧹 Checklist