Skip to content

[improvement][helm] Update controller tolerations to use with directive for consistency #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komer3 merged 3 commits into from
Dec 9, 2025
Merged

[improvement][helm] Update controller tolerations to use with directive for consistency #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0713a80
Update controller tolerations to use `with` directive for consistency
komer3 Dec 9, 2025
037f9bf
Update controller tolerations to remove NoSchedule toleration
komer3 Dec 9, 2025
9b4aa8f
Move default controller tolerations from template to values.yaml
komer3 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions helm-chart/csi-driver/templates/csi-linode-controller.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,9 @@ spec:
affinity:
{{- toYaml .Values.controller.affinity | nindent 8 }}
{{- end }}
{{- if .Values.controller.tolerations }}
{{- with .Values.controller.tolerations }}
tolerations:
{{- toYaml . | nindent 8 }}
{{- else }}
tolerations:
- effect: NoSchedule
operator: Exists
- key: CriticalAddonsOnly
operator: Exists
- effect: NoExecute
operator: Exists
{{- end }}
volumes:
- emptyDir: {}
Expand Down
6 changes: 5 additions & 1 deletion helm-chart/csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,11 @@ controller:
enabled: true
nodeSelector: {}
affinity: {}
tolerations: []
tolerations:
- key: CriticalAddonsOnly
operator: Exists
- effect: NoExecute
operator: Exists

daemonSet:
enabled: true
Expand Down
Loading