Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Dec 9, 2025

Replace if with with directive in the controller tolerations template block to match Helm best practices and maintain consistency with other conditional blocks in the template.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Replace `if` with `with` directive in the controller tolerations template block to match Helm best practices and maintain consistency with other conditional blocks in the template.
@komer3 komer3 requested review from a team as code owners December 9, 2025 17:32
@github-actions github-actions bot added the improvement for improvements in existing functionality in the changelog. label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (84f61dc) to head (9b4aa8f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #534   +/-   ##
=======================================
  Coverage   70.53%   70.53%           
=======================================
  Files          24       24           
  Lines        2118     2118           
=======================================
  Hits         1494     1494           
  Misses        496      496           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 closed this Dec 9, 2025
@komer3 komer3 reopened this Dec 9, 2025
@komer3 komer3 merged commit bc68bba into main Dec 9, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants