-
Notifications
You must be signed in to change notification settings - Fork 392
chore: [UIE-9926] - Bump jspdf to 4.0.0
#13248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d7047ec
bump jspdf to 4.0.0
abailly-akamai 11bd2e3
Merge branch 'develop' into bump-jspdf
abailly-akamai 63b9fc8
types and test
abailly-akamai 3d42686
oops buffer
abailly-akamai e5a306d
Added changeset: Bump jspdf to 4.0.0
abailly-akamai 1cc5e86
try CI without global
abailly-akamai 82e8003
Merge branch 'develop' into bump-jspdf
abailly-akamai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-13248-tech-stories-1767787781583.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Tech Stories | ||
| --- | ||
|
|
||
| Bump jspdf to 4.0.0 ([#13248](https://github.com/linode/manager/pull/13248)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -179,15 +179,15 @@ const addTitle = (doc: jsPDF, y: number, ...textStrings: Title[]) => { | |
| }; | ||
|
|
||
| // M3-6177 only make one request to get the logo | ||
| const getAkamaiLogo = () => { | ||
| return axios | ||
| .get(AkamaiLogo, { responseType: 'blob' }) | ||
| .then((res) => { | ||
| return URL.createObjectURL(res.data); | ||
| }) | ||
| .catch(() => { | ||
| return AkamaiLogo; | ||
| }); | ||
| const getAkamaiLogo = async () => { | ||
| const response = await axios.get(AkamaiLogo, { responseType: 'blob' }); | ||
|
|
||
| return new Promise<string>((resolve, reject) => { | ||
| const reader = new FileReader(); | ||
| reader.onloadend = () => resolve(reader.result as string); | ||
| reader.onerror = reject; | ||
| reader.readAsDataURL(response.data); | ||
| }); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tests were failing - this method is valid for both node (tests) and the browser |
||
| }; | ||
|
|
||
| interface PrintInvoiceOptions { | ||
|
|
@@ -324,12 +324,12 @@ export const printInvoice = async ( | |
| } | ||
| }; | ||
|
|
||
| export const printPayment = ( | ||
| export const printPayment = async ( | ||
| account: Account, | ||
| payment: Payment, | ||
| countryTax?: TaxDetail, | ||
| timezone?: string | ||
| ): PdfResult => { | ||
| ): Promise<PdfResult> => { | ||
| try { | ||
| const date = formatDate(payment.date, { | ||
| displayTime: true, | ||
|
|
@@ -340,7 +340,8 @@ export const printPayment = ( | |
| }); | ||
| doc.setFontSize(10); | ||
|
|
||
| doc.addImage(AkamaiLogo, 'JPEG', 160, 10, 120, 40, undefined, 'MEDIUM'); | ||
| const AkamaiLogoURL = await getAkamaiLogo(); | ||
| doc.addImage(AkamaiLogoURL, 'JPEG', 160, 10, 120, 40, undefined, 'MEDIUM'); | ||
|
|
||
| const leftHeaderYPosition = addLeftHeader( | ||
| doc, | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://www.npmjs.com/package/@types/jspdf?activeTab=readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I hate it when packages don't provide their own type-definitions!