chore: [UIE-9926] - Bump jspdf to 4.0.0
#13248
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
jspdf to 4.0.0jspdf to 4.0.0
abailly-akamai
commented
Jan 7, 2026
| "@types/eslint-plugin-jsx-a11y": "^6.10.0", | ||
| "@types/he": "^1.1.0", | ||
| "@types/history": "4", | ||
| "@types/jspdf": "^1.3.3", |
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Great! I hate it when packages don't provide their own type-definitions!
| reader.onloadend = () => resolve(reader.result as string); | ||
| reader.onerror = reject; | ||
| reader.readAsDataURL(response.data); | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
tests were failing - this method is valid for both node (tests) and the browser
Member
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! PDF generation looks good from my testing. Left one comment about the window.location patch
| "@types/eslint-plugin-jsx-a11y": "^6.10.0", | ||
| "@types/he": "^1.1.0", | ||
| "@types/history": "4", | ||
| "@types/jspdf": "^1.3.3", |
Member
There was a problem hiding this comment.
Great! I hate it when packages don't provide their own type-definitions!
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
bnussman-akamai
approved these changes
Jan 8, 2026
bnussman-akamai
added
the
Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened my own PR in favor of #13241
This update resulted in some type pollution which were tricky to resolve (mostly in test files).
This should be tested properly!
Changes
Bumps jspdf from 3.0.2 to 4.0.0.
Release notes
Sourced from jspdf's releases.
Commits
e6cf03d4.0.0a688c8frestrict file system access in node build (#3931)a504e973.0.4de802abFix Incorrect Typing for Margins in the TableConfig Interface Definition (#3816)87162d1chore: bump checkout, setup-node, and stale actions (#3907)e7dc622Fix: Context2d font regex too restrictive ( #3904 ) (#3906)e080935Do not add pages dynamically unless autoPaging is enabled (#3915)c768910add package.json exports field (#3903)c10d90cFix API.internal.pages not being updated when restoring a RenderTarget ( #389...2db3d9dfix font list cache invalidation issue in context2d module (#3891)What to test