Skip to content

chore: [UIE-9926] - Bump jspdf to 4.0.0 #13248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abailly-akamai merged 7 commits into from
Jan 12, 2026
Merged

chore: [UIE-9926] - Bump jspdf to 4.0.0 #13248

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7047ec
bump jspdf to 4.0.0
abailly-akamai Jan 7, 2026
11bd2e3
Merge branch 'develop' into bump-jspdf
abailly-akamai Jan 7, 2026
63b9fc8
types and test
abailly-akamai Jan 7, 2026
3d42686
oops buffer
abailly-akamai Jan 7, 2026
e5a306d
Added changeset: Bump jspdf to 4.0.0
abailly-akamai Jan 7, 2026
1cc5e86
try CI without global
abailly-akamai Jan 8, 2026
82e8003
Merge branch 'develop' into bump-jspdf
abailly-akamai Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13248-tech-stories-1767787781583.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Bump jspdf to 4.0.0 ([#13248](https://github.com/linode/manager/pull/13248))
3 changes: 1 addition & 2 deletions packages/manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"he": "^1.2.0",
"immer": "^9.0.6",
"ipaddr.js": "^1.9.1",
"jspdf": "^3.0.2",
"jspdf": "^4.0.0",
"jspdf-autotable": "^5.0.2",
"launchdarkly-react-client-sdk": "3.0.10",
"libphonenumber-js": "^1.10.6",
Expand Down Expand Up @@ -140,7 +140,6 @@
"@types/eslint-plugin-jsx-a11y": "^6.10.0",
"@types/he": "^1.1.0",
"@types/history": "4",
"@types/jspdf": "^1.3.3",
Copy link
Contributor Author

@abailly-akamai abailly-akamai Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://www.npmjs.com/package/@types/jspdf?activeTab=readme

Copy link
Member

@bnussman-akamai bnussman-akamai Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I hate it when packages don't provide their own type-definitions!

"@types/luxon": "3.4.2",
"@types/markdown-it": "^14.1.2",
"@types/md5": "^2.1.32",
Expand Down
4 changes: 2 additions & 2 deletions packages/manager/src/dev-tools/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ export const saveSeedsCountMap = (countMap: { [key: string]: number }) => {
/**
* Retrieves the presets map from local storage.
*/
export const getExtraPresetsMap = (): {
export const getExtraPresetsMap = (): Partial<{
[K in MockPresetExtraId]: number;
} => {
}> => {
const encodedPresetsMap = localStorage.getItem(LOCAL_STORAGE_PRESETS_MAP_KEY);

return encodedPresetsMap ? JSON.parse(encodedPresetsMap) : {};
Expand Down
4 changes: 2 additions & 2 deletions .../manager/src/features/Billing/BillingPanels/BillingActivityPanel/BillingActivityPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ export const BillingActivityPanel = React.memo((props: Props) => {
);

const downloadPaymentPDF = React.useCallback(
(paymentId: number) => {
async (paymentId: number) => {
const payment = payments?.find(
(thisPayment) => thisPayment.id === paymentId
);
Expand All @@ -307,7 +307,7 @@ export const BillingActivityPanel = React.memo((props: Props) => {
taxes?.date,
taxes?.country_tax
);
const result = printPayment(account, payment, countryTax);
const result = await printPayment(account, payment, countryTax);

if (result.status === 'error') {
pdfErrors.add(id);
Expand Down
7 changes: 6 additions & 1 deletion packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,12 @@ describe('PdfGenerator', () => {
});

// Call the printPayment function
const pdfResult = printPayment(account, payment, countryTax, timezone);
const pdfResult = await printPayment(
account,
payment,
countryTax,
timezone
);

// Expect the PDF generation to be successful
expect(pdfResult.status).toEqual('success');
Expand Down
25 changes: 13 additions & 12 deletions packages/manager/src/features/Billing/PdfGenerator/PdfGenerator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,15 @@ const addTitle = (doc: jsPDF, y: number, ...textStrings: Title[]) => {
};

// M3-6177 only make one request to get the logo
const getAkamaiLogo = () => {
return axios
.get(AkamaiLogo, { responseType: 'blob' })
.then((res) => {
return URL.createObjectURL(res.data);
})
.catch(() => {
return AkamaiLogo;
});
const getAkamaiLogo = async () => {
const response = await axios.get(AkamaiLogo, { responseType: 'blob' });

return new Promise<string>((resolve, reject) => {
const reader = new FileReader();
reader.onloadend = () => resolve(reader.result as string);
reader.onerror = reject;
reader.readAsDataURL(response.data);
});
Copy link
Contributor Author

@abailly-akamai abailly-akamai Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests were failing - this method is valid for both node (tests) and the browser

};

interface PrintInvoiceOptions {
Expand Down Expand Up @@ -324,12 +324,12 @@ export const printInvoice = async (
}
};

export const printPayment = (
export const printPayment = async (
account: Account,
payment: Payment,
countryTax?: TaxDetail,
timezone?: string
): PdfResult => {
): Promise<PdfResult> => {
try {
const date = formatDate(payment.date, {
displayTime: true,
Expand All @@ -340,7 +340,8 @@ export const printPayment = (
});
doc.setFontSize(10);

doc.addImage(AkamaiLogo, 'JPEG', 160, 10, 120, 40, undefined, 'MEDIUM');
const AkamaiLogoURL = await getAkamaiLogo();
doc.addImage(AkamaiLogoURL, 'JPEG', 160, 10, 120, 40, undefined, 'MEDIUM');

const leftHeaderYPosition = addLeftHeader(
doc,
Expand Down
10 changes: 10 additions & 0 deletions packages/manager/src/testSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@
unobserve() {}
};

// Fix TypeScript type pollution for window.location in tests
// Cypress types (via Mocha) pollute the Window interface, making location
// typed as 'string & Location' which is impossible to assign to.
// This global declaration fixes it for Vitest tests.
declare global {
interface Window {

Check warning on line 76 in packages/manager/src/testSetup.ts

View workflow job for this annotation

GitHub Actions / ESLint Review (manager) 

[eslint] reported by reviewdog 🐶
'Window' is defined but never used.

Raw Output:
{"ruleId":"no-unused-vars","severity":1,"message":"'Window' is defined but never used.","line":76,"column":13,"nodeType":"Identifier","messageId":"unusedVar","endLine":76,"endColumn":19,"suggestions":[{"messageId":"removeVar","data":{"varName":"Window"},"fix":{"range":[1772,1778],"text":""},"desc":"Remove unused variable 'Window'."}]}
location: Location;
}
}

/**
***************************************
* Custom matchers & matchers overrides
Expand Down
26 changes: 9 additions & 17 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.