Skip to content

Conversation

@tanushree-akamai
Copy link
Contributor

@tanushree-akamai tanushree-akamai commented Jan 7, 2026

Description 📝

Address post-demo feedback for Network Load Balancers (points 1- 3 from the ticket).

Changes 🔄

List any change(s) relevant to the reviewer.

  • Modify empty state message casing to: 'High capacity network load balancing service'
  • Rename LKE column to 'Cluster' on NLB list & detail page
  • Modify columns displayed in smaller screen size: show IPv6 instead of IPv4 (IPv4 hidden)

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

  1. Modify empty state message casing to: 'High capacity network load balancing service'
    Screenshot 2026-01-07 at 5 33 57 PM|

  2. Rename LKE column to 'Cluster' on NLB list & detail page
    Screenshot 2026-01-07 at 5 37 39 PM

  3. Reorder mobile view: show IPv6 before IPv4 (IPv4 hidden on mobile)
    Screenshot 2026-01-07 at 5 38 37 PM

How to test 🧪

Verification steps

  • Turn on Legacy Server Handlers in MSW
  • Enable Network Load Balancer feature from dev tools
  • Navigate to /netloadbalancers

For point 1:

  • Update the serverHandlers.ts so the /netloadbalancers mock API returns an empty array.
  • Verify empty state message

For point 2:

  • Verify Cluster column in /netloadbalancers list
  • Verify NLB detail page by clicking on a netloadbalancer

For point 3:

  • Resize browser width to <960px
  • "Virtual IP (IPv6)" column is visible and displayed
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@dmcintyr-akamai
Copy link
Contributor

fyi the clone-linode.spec.ts test failed most likely bc of server side issue. prob not related to your pr.

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Just make sure you add a changeset!

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✅
Verification steps ✅

As Banks mentioned, we'll need a changeset here for the manager package (Upcoming Features category)

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 7, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 860 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing860 Passing11 Skipped45m 13s

@tanushree-akamai tanushree-akamai merged commit d423815 into linode:develop Jan 8, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Network Load Balancers Related to Network Load Balancers Ready for Review

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants