Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

NLB post-demo feedback-fix empty state title casing,rename LKE-E to Cluster and adjust column visibility for smaller screens to prioritize IPv6 ([#13250](https://github.com/linode/manager/pull/13250))
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export const NetworkLoadBalancerDetailBody = (
{regionLabel}
</Box>
<Box>
<StyledTypography>LKE-E Cluster</StyledTypography>
<StyledTypography>Cluster</StyledTypography>
{lkeCluster ? (
<>
<Link
accessibleAriaLabel={`LKE-E Cluster ${lkeCluster.label}`}
accessibleAriaLabel={`Cluster ${lkeCluster.label}`}
className="secondaryLink"
to={`/kubernetes/clusters/${lkeCluster.id}`}
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ describe('NetworkLoadBalancersDetail', () => {
expect(getByText('Region')).toBeVisible();
expect(getByText('US, Newark, NJ')).toBeVisible();

expect(getByText('LKE-E Cluster')).toBeVisible();
expect(getByText('Cluster')).toBeVisible();
expect(getByText('None')).toBeVisible();

expect(getByText('Network Load Balancer ID')).toBeVisible();
Expand All @@ -121,7 +121,7 @@ describe('NetworkLoadBalancersDetail', () => {

const { getByText } = renderWithTheme(<NetworkLoadBalancersDetail />);

expect(getByText('LKE-E Cluster')).toBeVisible();
expect(getByText('Cluster')).toBeVisible();
expect(getByText(nlbFactory.lke_cluster!.label)).toBeVisible();
expect(
getByText(`(ID: ${nlbFactory.lke_cluster!.id})`, {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,18 @@ export const NetworkLoadBalancerTableRow = (props: NetworkLoadBalancer) => {
<TableCell data-qa-ports>
<PortsDisplay ports={portStrings} />
</TableCell>
<TableCell data-qa-ipv4>
<IPAddress ips={[address_v4]} isHovered={isHovered} />
</TableCell>
<Hidden mdDown>
<TableCell data-qa-ipv6>
{address_v6 ? (
<IPAddress ips={[address_v6]} isHovered={isHovered} />
) : (
'None'
)}
<TableCell data-qa-ipv4>
<IPAddress ips={[address_v4]} isHovered={isHovered} />
</TableCell>
</Hidden>
<TableCell data-qa-ipv6>
{address_v6 ? (
<IPAddress ips={[address_v6]} isHovered={isHovered} />
) : (
'None'
)}
</TableCell>
<TableCell data-qa-lke-cluster>
{lke_cluster ? (
<Link
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ export const NetworkLoadBalancersLanding = () => {
<TableCell>ID</TableCell>
</Hidden>
<TableCell>Listener Ports</TableCell>
<TableCell>Virtual IP (IPv4)</TableCell>
<Hidden mdDown>
<TableCell>Virtual IP (IPv6)</TableCell>
<TableCell>Virtual IP (IPv4)</TableCell>
</Hidden>
<TableCell>LKE-E Cluster</TableCell>
<TableCell>Virtual IP (IPv6)</TableCell>
<TableCell>Cluster</TableCell>
<Hidden mdDown>
<TableCell>Region</TableCell>
</Hidden>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const NetworkLoadBalancersLandingEmptyState = () => {
]}
icon={NetworkIcon}
isEntity
subtitle="High Capacity load balancing service"
subtitle="High capacity network load balancing service"
title="Network Load Balancer"
>
<Typography variant="subtitle1">
Expand Down