-
Notifications
You must be signed in to change notification settings - Fork 391
change: [UIE-9890] - changes related to private IP field in create linode flow #13253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
packages/manager/src/features/Linodes/LinodeCreate/Addons/PrivateIP.tsx
Outdated
Show resolved
Hide resolved
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
| You can use VPC for private networking instead. NodeBalancers | ||
| now connect to backend nodes without a private IPv4 address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copy makes sense to me but here's an alternative wording that may sound better
| You can use VPC for private networking instead. NodeBalancers | |
| now connect to backend nodes without a private IPv4 address. | |
| Private networking can now be handled through VPCs, allowing NodeBalancers to connect to backend nodes without private IPv4 addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the suggestion I got from UX but the wordings are yet to be finalized by tech writer. Our tech writer is reviewing the descriptions and once we get feedback, I will be raising a separate PR to update these descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, sounds good!
Description 📝
As part of this PR, information text related to private IP has been updated along with a notification banner in Linode create flow. Also this field will be hidden for linode interfaces type.
Changes 🔄
Under linode create flow
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
NA
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
/linodes/create/osand ensure above mentioned changes are visible.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅