Skip to content

change: [UIE-9890] - changes related to private IP field in create linode flow #13253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grevanak-akamai merged 3 commits into from
Jan 9, 2026
Merged

change: [UIE-9890] - changes related to private IP field in create linode flow #13253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44eb1a0
change: [UIE-9890] - changes related to private IP field in create li…
grevanak-akamai Jan 7, 2026
bb83737
Added changeset: Changes related to private IP field in create linode…
grevanak-akamai Jan 7, 2026
7e28769
Addressed review comments
grevanak-akamai Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13253-changed-1767795144176.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Changes related to private IP field in create linode flow ([#13253](https://github.com/linode/manager/pull/13253))
30 changes: 30 additions & 0 deletions packages/manager/src/features/Linodes/LinodeCreate/Addons/Addons.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,34 @@ describe('Linode Create Addons', () => {
'Backups and Private IP are not available for distributed regions.'
);
});

it('should hide the Private IP addon if interface generation is "linode"', () => {
const { queryByText } = renderWithThemeAndHookFormContext({
component: <Addons />,
useFormOptions: {
values: {
interface_generation: 'linode',
},
},
});

const privateIPLabel = queryByText('Private IP');

expect(privateIPLabel).not.toBeInTheDocument();
});

it('should show the Private IP addon if interface generation is not "linode"', () => {
const { queryByText } = renderWithThemeAndHookFormContext({
component: <Addons />,
useFormOptions: {
values: {
interface_generation: 'legacy_config',
},
},
});

const privateIPLabel = queryByText('Private IP');

expect(privateIPLabel).toBeVisible();
});
});
9 changes: 7 additions & 2 deletions packages/manager/src/features/Linodes/LinodeCreate/Addons/Addons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import { PrivateIP } from './PrivateIP';
import type { CreateLinodeRequest } from '@linode/api-v4';

export const Addons = () => {
const regionId = useWatch<CreateLinodeRequest, 'region'>({ name: 'region' });
const [regionId, interfaceGeneration] = useWatch<
CreateLinodeRequest,
['region', 'interface_generation']
>({ name: ['region', 'interface_generation'] });

const { data: regions } = useRegionsQuery();

Expand All @@ -21,6 +24,8 @@ export const Addons = () => {
const isDistributedRegionSelected =
selectedRegion?.site_type === 'distributed';

const shouldShowPrivateIP = interfaceGeneration !== 'linode';

return (
<Paper data-qa-add-ons>
<Stack spacing={2}>
Expand All @@ -33,7 +38,7 @@ export const Addons = () => {
)}
<Stack divider={<Divider />} spacing={2}>
<Backups />
<PrivateIP />
{shouldShowPrivateIP && <PrivateIP />}
</Stack>
</Stack>
</Paper>
Expand Down
14 changes: 12 additions & 2 deletions packages/manager/src/features/Linodes/LinodeCreate/Addons/PrivateIP.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useRegionsQuery } from '@linode/queries';
import {
Checkbox,
FormControlLabel,
NewFeatureChip,
Notice,
Stack,
Typography,
Expand Down Expand Up @@ -55,9 +56,18 @@ export const PrivateIP = () => {
/>
)}
<Typography component="span" display="block" variant="body1">
Use Private IP for a backend node to a NodeBalancer. Use VPC instead
for private communication between your Linodes.
Lets you connect with other Linodes in the same region over the data
center&apos;s private network, without using a public IPv4 address.
</Typography>
<Notice variant="tip">
<Stack alignItems="center" direction="row" spacing={1}>
<NewFeatureChip />
<Typography>
You can use VPC for private networking instead. NodeBalancers
now connect to backend nodes without a private IPv4 address.
Comment on lines +66 to +67
Copy link
Member

@bnussman-akamai bnussman-akamai Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copy makes sense to me but here's an alternative wording that may sound better

Suggested change
You can use VPC for private networking instead. NodeBalancers
now connect to backend nodes without a private IPv4 address.
Private networking can now be handled through VPCs, allowing NodeBalancers to connect to backend nodes without private IPv4 addresses.

Copy link
Contributor Author

@grevanak-akamai grevanak-akamai Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the suggestion I got from UX but the wordings are yet to be finalized by tech writer. Our tech writer is reviewing the descriptions and once we get feedback, I will be raising a separate PR to update these descriptions.

Copy link
Member

@bnussman-akamai bnussman-akamai Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, sounds good!

</Typography>
</Stack>
</Notice>
</Stack>
}
onChange={field.onChange}
Expand Down