Skip to content

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR fixes an issue where, after changing a role the last role/entity on a page, the table shows “No items to display” instead of resetting to the previous page.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update logic for handleDialogClose func

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screen.Recording.2026-01-16.at.9.38.23.AM.mov
Screen.Recording.2026-01-16.at.9.39.22.AM.mov
Screen.Recording.2026-01-16.at.9.50.41.AM.mov
Screen.Recording.2026-01-16.at.9.51.44.AM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • use iam account
  • use child account + IAM Delegation flag is enabled

Reproduction steps

(How to reproduce the issue, if applicable)

(How to reproduce the issue, if applicable)

Note: it also can be reproduced for Parent/Child - /defaults/roles, but to test it there, this PR needs to be merged first.

  • Go to /iam/users/:username/roles for a user with 26 roles assigned. Table size should be set to 25.
  • Assign the same entity to linode_admin and linode_contributor.
  • Try to change the role for linode_admin to linode_contributor for that same entity.
  • Save changes.

Verification steps

(How to verify changes)

  • The current tables should be switched to the previous page.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner January 16, 2026 10:07
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing854 Passing11 Skipped40m 10s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants