Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13285-fixed-1768558039969.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

IAM: changing entity/role can cause an empty page ([#13285](https://github.com/linode/manager/pull/13285))
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,17 @@ export const AssignedEntitiesTable = ({ username }: Props) => {
setSelectedRole(role);
};

const handleRemoveAssignmentDialogClose = () => {
setIsRemoveAssignmentDialogOpen(false);
/**
* Closes the appropriate assignment-related dialog and adjusts pagination if needed.
*
* @param drawerMode Optional mode indicating which dialog should be closed.
*/
const handleDialogClose = (drawerMode?: DrawerModes) => {
if (drawerMode && drawerMode === 'change-role-for-entity') {
setIsChangeRoleForEntityDrawerOpen(false);
} else {
setIsRemoveAssignmentDialogOpen(false);
}
// If we just deleted the last one on a page, reset to the previous page.
const removedLastOnPage =
filteredAndSortedRoles.length % pagination.pageSize === 1;
Expand Down Expand Up @@ -362,13 +371,13 @@ export const AssignedEntitiesTable = ({ username }: Props) => {
</Table>
<ChangeRoleForEntityDrawer
mode={drawerMode}
onClose={() => setIsChangeRoleForEntityDrawerOpen(false)}
onClose={() => handleDialogClose(drawerMode)}
open={isChangeRoleForEntityDrawerOpen}
role={selectedRole}
username={username}
/>
<RemoveAssignmentConfirmationDialog
onClose={() => handleRemoveAssignmentDialogClose()}
onClose={() => handleDialogClose()}
open={isRemoveAssignmentDialogOpen}
role={selectedRole}
username={username}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,17 @@ export const AssignedRolesTable = () => {
setSelectedRole(role);
};

const handleRemoveRoleDialogClose = () => {
setIsUnassignRoleDialogOpen(false);

/**
* Closes the appropriate assignment-related dialog and adjusts pagination if needed.
*
* @param drawerMode Optional mode indicating which dialog should be closed.
*/
const handleDialogClose = (drawerMode?: DrawerModes) => {
if (drawerMode && drawerMode === 'change-role') {
setIsChangeRoleDrawerOpen(false);
} else {
setIsUnassignRoleDialogOpen(false);
}
// If we just deleted the last one on a page, reset to the previous page.
const removedLastOnPage =
filteredAndSortedRoles.length % pagination.pageSize === 1;
Expand Down Expand Up @@ -453,12 +461,12 @@ export const AssignedRolesTable = () => {
/>
<ChangeRoleDrawer
mode={drawerMode}
onClose={() => setIsChangeRoleDrawerOpen(false)}
onClose={() => handleDialogClose(drawerMode)}
open={isChangeRoleDrawerOpen}
role={selectedRole}
/>
<UnassignRoleConfirmationDialog
onClose={() => handleRemoveRoleDialogClose()}
onClose={() => handleDialogClose()}
open={isUnassignRoleDialogOpen}
role={selectedRole}
/>
Expand Down