wdc: rework log retrieval and parsing #2585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only need to retrieve the log page once, rather than once per field to be parsed. This also fixes some endianness issues when handling the parsed data entries. Signed-off-by: Brandon Paupore <[email protected]>
brandon-paupore-sndk
force-pushed
the
drive-status-rework
branch
from
a6d3601 to
e1341a0
Compare
jeff-lien-sndk
approved these changes
Nov 26, 2024
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only need to retrieve the log page once, rather than once per field to be parsed. This also fixes some endianness issues when handling the parsed data entries.