nvme: Added message key for printable eye in normal format #2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Printable Eye message key missing for eye plotting -Removed malloc for vsdata as memory cleanup taken care by caller Signed-off-by: Sivaprasad Gutha <[email protected]>
Contributor
Author
|
@igaw I've missed this in the previous PR. Added Message key for printable eye and removed malloc for vsdata and the memory cleanup is already took care in caller function. Please find the attached test results and the valgrind checks. valgrind-out_normal.txt |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Printable Eye message key missing for eye plotting
-Removed malloc for vsdata as memory cleanup taken care by caller