Skip to content

nvme: Added message key for printable eye in normal format #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Jul 16, 2025
Merged

nvme: Added message key for printable eye in normal format #2869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions nvme-print-stdout.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,7 @@ static void stdout_eom_printable_eye(struct nvme_eom_lane_desc *lane)
char *eye = (char *)lane->eye_desc;
int i, j;

printf("Printable Eye:\n");
for (i = 0; i < le16_to_cpu(lane->nrows); i++) {
for (j = 0; j < le16_to_cpu(lane->ncols); j++)
printf("%c", eye[i * le16_to_cpu(lane->ncols) + j]);
Expand Down Expand Up @@ -817,17 +818,11 @@ static void stdout_phy_rx_eom_descs(struct nvme_phy_rx_eom_log *log)
if (edlen == 0)
continue;

/* Hex dump Vendor Specific Eye Data */
vsdata = malloc(edlen);
if (!vsdata)
return;

vsdataoffset = (nrows * ncols) + sizeof(struct nvme_eom_lane_desc);
vsdata = (unsigned char *)((unsigned char *)desc + vsdataoffset);
printf("Eye Data:\n");
d(vsdata, edlen, 16, 1);
printf("\n");
free(vsdata);

p += log->dsize;
}
Expand Down