Skip to content

Conversation

@MaisenbacherD
Copy link
Contributor

Introduce init_pi_tags helper function that is called for all IO commands, to ensure uniform behavior.

Renaming related variables to match the spec.

@MaisenbacherD
Copy link
Contributor Author

@igaw Not sure how to address the check patch warnings about the exceeding char limit. I tried to fit the changes to the surrounding codebase.
I could fix those warning up by also patching the lines that I didn't touch to have a uniform style. :)

@igaw
Copy link
Collaborator

igaw commented Nov 28, 2025

Just ingore those checkpatch warnings. It's just a stupid reporting tool and we should not blindly follow it. Your changes look good to me. The only thing I would probably change is the overlong lines for the function definition.

@igaw
Copy link
Collaborator

igaw commented Dec 1, 2025

Would you mind to rebase it to the current master. Due the passthru updates some changes are necessary, though it should be fairly simple :)

Introduce `init_pi_tags` helper function that is called for all
IO commands, to ensure uniform behavior.

Renaming related variables to match the spec.

Signed-off-by: Dennis Maisenbacher <[email protected]>
@MaisenbacherD
Copy link
Contributor Author

Done :)
I made sure to shorten the function definitions.

The rebase even discovered a bug in init_pi_tags. It accepts the cmd as a pointer and I previously passed a reference of that pointer to the underlying nvme_init_var_size_tags function, which was not correct. The explicit casting to nvme_passthru_cmd64 * covered up this mistake.

@igaw
Copy link
Collaborator

igaw commented Dec 2, 2025

Yeah, type casts have always a bit of a smell. Nice, thanks!

@igaw igaw merged commit bcf72cf into linux-nvme:master Dec 2, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants