ci: This PR is to trigger periodic CI testing by systemroller · Pull Request #227 · linux-system-roles/vpn

systemroller · 2026-01-11T04:42:39Z

This PR is for the purpose of triggering periodic CI testing. We don't currently have a way to trigger CI without a PR, so this PR serves that purpose.

Summary by Sourcery

Tests:

Introduce a dump_packages callback plugin that records non-removed packages used by Ansible package-related tasks during test execution.

systemroller · 2026-01-11T04:42:40Z

[citest]

sourcery-ai · 2026-01-11T04:42:45Z

Reviewer's Guide

Adds an Ansible aggregate callback plugin used in CI to capture and print all non-removed packages requested via package-related modules, enabling inspection of package usage across test runs.

File-Level Changes

Change	Details	Files
Introduce an Ansible callback plugin to aggregate and log packages used by package-related tasks during CI runs.	Create a new aggregate callback plugin class `CallbackModule` extending `CallbackBase` with appropriate metadata (version, type, name, and compatibility flags) Implement `v2_runner_on_ok` to intercept successful tasks, filter for `package`, `dnf`, and `yum` actions where state is not `absent`, and extract requested package names from `invocation.module_args.name` for both single and multi-result task formats Aggregate all package names into a set and output a deterministic, sorted, space-separated list prefixed with `lsrpackages:` via the plugin display interface for downstream consumption in CI and image build tooling	`tests/callback_plugins/dump_packages.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

tests/callback_plugins/dump_packages.py

+                result._result["results"], list
+            ):
+                results = result._result["results"]
+            for item in results:


In general, to fix a “potentially uninitialized local variable” problem, either (1) initialize the variable to a safe default before any conditional assignments or (2) ensure all control-flow paths that reach its use have definitely assigned it (for example, by adding else cases or early returns).

Here, the safest change without altering existing behavior is:

Initialize results to an empty list before the if/elif chain.

After the chain, only iterate over results if it is non-empty; otherwise, simply skip the loop so no UnboundLocalError can occur.
This preserves current behavior when results is defined as before, while making the code no-op (rather than crash) in the rare case that neither condition is met.

Concretely in tests/callback_plugins/dump_packages.py:

In CallbackModule.v2_runner_on_ok, add results = [] right after packages = set().

Wrap the for item in results: loop and subsequent package processing in an if results: guard so it only executes when results has been set to something meaningful.

No new imports or helper methods are required.

systemroller · 2026-01-18T06:22:34Z

[citest]

systemroller · 2026-01-25T04:47:57Z

[citest]

systemroller · 2026-02-01T05:19:32Z

[citest]

systemroller · 2026-02-08T05:21:10Z

[citest]

systemroller · 2026-02-15T05:16:20Z

[citest]

systemroller · 2026-02-22T05:13:37Z

[citest]

systemroller · 2026-03-01T05:14:35Z

[citest]

systemroller · 2026-03-08T05:06:45Z

[citest]

systemroller · 2026-03-15T05:25:31Z

[citest]

systemroller · 2026-03-22T05:16:31Z

[citest]

systemroller · 2026-03-29T05:40:42Z

[citest]

github-actions bot force-pushed the weekly-ci branch from 5fe3358 to 70bb771 Compare January 11, 2026 04:42

github-advanced-security bot found potential problems Jan 11, 2026

View reviewed changes

github-actions bot force-pushed the weekly-ci branch from 70bb771 to d662139 Compare January 18, 2026 06:22

github-actions bot force-pushed the weekly-ci branch from 74b344f to 9415af4 Compare February 8, 2026 05:21

github-actions bot force-pushed the weekly-ci branch from 9415af4 to e9013d9 Compare February 15, 2026 05:16

github-actions bot force-pushed the weekly-ci branch from e9013d9 to 2afac9d Compare February 22, 2026 05:13

github-actions bot force-pushed the weekly-ci branch from 5079045 to 082ffea Compare March 8, 2026 05:06

github-actions bot force-pushed the weekly-ci branch from 082ffea to 7ff7e45 Compare March 15, 2026 05:25

github-actions bot added 11 commits March 22, 2026 05:16

ci: This PR is to trigger periodic CI testing

60226c8

ci: This PR is to trigger periodic CI testing

7aa896b

ci: This PR is to trigger periodic CI testing

1cba3d5

ci: This PR is to trigger periodic CI testing

8847a23

ci: This PR is to trigger periodic CI testing

1036e0a

ci: This PR is to trigger periodic CI testing

f3fee75

ci: This PR is to trigger periodic CI testing

39e4642

ci: This PR is to trigger periodic CI testing

f767c50

ci: This PR is to trigger periodic CI testing

3679c36

ci: This PR is to trigger periodic CI testing

db2e2fd

ci: This PR is to trigger periodic CI testing

d082154

github-actions bot added 26 commits March 22, 2026 05:16

ci: This PR is to trigger periodic CI testing

d88592b

ci: This PR is to trigger periodic CI testing

5c9fb46

ci: This PR is to trigger periodic CI testing

d187632

ci: This PR is to trigger periodic CI testing

ace293b

ci: This PR is to trigger periodic CI testing

298dbb3

ci: This PR is to trigger periodic CI testing

2a5b8ea

ci: This PR is to trigger periodic CI testing

2e0a078

ci: This PR is to trigger periodic CI testing

a8302fe

ci: This PR is to trigger periodic CI testing

2e78bdd

ci: This PR is to trigger periodic CI testing

43560f8

ci: This PR is to trigger periodic CI testing

4c1d718

ci: This PR is to trigger periodic CI testing

d7a8e4e

ci: This PR is to trigger periodic CI testing

b6b48ae

ci: This PR is to trigger periodic CI testing

4bec6b0

ci: This PR is to trigger periodic CI testing

d66d666

ci: This PR is to trigger periodic CI testing

ee08582

ci: This PR is to trigger periodic CI testing

844a706

ci: This PR is to trigger periodic CI testing

8a0c630

ci: This PR is to trigger periodic CI testing

0fd8536

ci: This PR is to trigger periodic CI testing

9a738f3

ci: This PR is to trigger periodic CI testing

a60cf03

ci: This PR is to trigger periodic CI testing

fcfd58a

ci: This PR is to trigger periodic CI testing

8271d78

ci: This PR is to trigger periodic CI testing

907aa13

ci: This PR is to trigger periodic CI testing

1714d1a

ci: This PR is to trigger periodic CI testing

47e3088

github-actions bot force-pushed the weekly-ci branch from 7ff7e45 to 47e3088 Compare March 22, 2026 05:16

ci: This PR is to trigger periodic CI testing

8fb0f83

@@ -45,20 +45,22 @@
                         and fields["args"].get("state") != "absent"
                     ):
                         packages = set()
+                        results = []
                         if "invocation" in result._result:
                             results = [result._result]
                         elif "results" in result._result and isinstance(
                             result._result["results"], list
                         ):
                             results = result._result["results"]
-                        for item in results:
-                            pkgs = item["invocation"]["module_args"]["name"]
-                            if isinstance(pkgs, list):
-                                for ii in pkgs:
-                                    packages.add(ii)
-                            else:
-                                packages.add(pkgs)
-                        # tell python black that this line is ok
-                        # fmt: off
-                        self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
-                        # fmt: on
+                        if results:
+                            for item in results:
+                                pkgs = item["invocation"]["module_args"]["name"]
+                                if isinstance(pkgs, list):
+                                    for ii in pkgs:
+                                        packages.add(ii)
+                                else:
+                                    packages.add(pkgs)
+                            # tell python black that this line is ok
+                            # fmt: off
+                            self._display.display("lsrpackages: " + " ".join(sorted(list(packages))))
+                            # fmt: on

Conversation

systemroller commented Jan 11, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

systemroller commented Jan 11, 2026

Uh oh!

sourcery-ai bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Check failure

Copilot Autofix

systemroller commented Jan 18, 2026

Uh oh!

systemroller commented Jan 25, 2026

Uh oh!

systemroller commented Feb 1, 2026

Uh oh!

systemroller commented Feb 8, 2026

Uh oh!

systemroller commented Feb 15, 2026

Uh oh!

systemroller commented Feb 22, 2026

Uh oh!

systemroller commented Mar 1, 2026

Uh oh!

systemroller commented Mar 8, 2026

Uh oh!

systemroller commented Mar 15, 2026

Uh oh!

systemroller commented Mar 22, 2026

Uh oh!

systemroller commented Mar 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

systemroller commented Jan 11, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 11, 2026 •

edited

Loading