-
Notifications
You must be signed in to change notification settings - Fork 14
ci: This PR is to trigger periodic CI testing #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
systemroller
wants to merge
131
commits into
main
Choose a base branch
from
weekly-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
131 commits
Select commit
Hold shift + click to select a range
60226c8
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7aa896b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1cba3d5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8847a23
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1036e0a
ci: This PR is to trigger periodic CI testing
github-actions[bot] f3fee75
ci: This PR is to trigger periodic CI testing
github-actions[bot] 39e4642
ci: This PR is to trigger periodic CI testing
github-actions[bot] f767c50
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3679c36
ci: This PR is to trigger periodic CI testing
github-actions[bot] db2e2fd
ci: This PR is to trigger periodic CI testing
github-actions[bot] d082154
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9eb1b54
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5151234
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5574615
ci: This PR is to trigger periodic CI testing
github-actions[bot] dae49bc
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5b5a177
ci: This PR is to trigger periodic CI testing
github-actions[bot] 13b4334
ci: This PR is to trigger periodic CI testing
github-actions[bot] 31c0ca9
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0ecd63d
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7c27ced
ci: This PR is to trigger periodic CI testing
github-actions[bot] d994ac5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 501dec2
ci: This PR is to trigger periodic CI testing
github-actions[bot] b80e10a
ci: This PR is to trigger periodic CI testing
github-actions[bot] b8ff22c
ci: This PR is to trigger periodic CI testing
github-actions[bot] beeda55
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7385a16
ci: This PR is to trigger periodic CI testing
github-actions[bot] df5fe09
ci: This PR is to trigger periodic CI testing
github-actions[bot] 61a59c4
ci: This PR is to trigger periodic CI testing
github-actions[bot] 68e4239
ci: This PR is to trigger periodic CI testing
github-actions[bot] de8759c
ci: This PR is to trigger periodic CI testing
github-actions[bot] c5f240a
ci: This PR is to trigger periodic CI testing
github-actions[bot] fc793cb
ci: This PR is to trigger periodic CI testing
github-actions[bot] 56286b7
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7acfa4e
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1531eb8
ci: This PR is to trigger periodic CI testing
github-actions[bot] 14a9150
ci: This PR is to trigger periodic CI testing
github-actions[bot] d83deb8
ci: This PR is to trigger periodic CI testing
github-actions[bot] e22cfb5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6f2440d
ci: This PR is to trigger periodic CI testing
github-actions[bot] b42ae82
ci: This PR is to trigger periodic CI testing
github-actions[bot] 26dc4e3
ci: This PR is to trigger periodic CI testing
github-actions[bot] 72032a1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7f87351
ci: This PR is to trigger periodic CI testing
github-actions[bot] 82a7194
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2f7141e
ci: This PR is to trigger periodic CI testing
github-actions[bot] bed97d1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0e34217
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1b7f5a1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6bbdf43
ci: This PR is to trigger periodic CI testing
github-actions[bot] 734ff28
ci: This PR is to trigger periodic CI testing
github-actions[bot] 06e79d2
ci: This PR is to trigger periodic CI testing
github-actions[bot] 035f4b2
ci: This PR is to trigger periodic CI testing
github-actions[bot] b9fff03
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6b0dce8
ci: This PR is to trigger periodic CI testing
github-actions[bot] d2371e7
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6846753
ci: This PR is to trigger periodic CI testing
github-actions[bot] 07fcf85
ci: This PR is to trigger periodic CI testing
github-actions[bot] 142d837
ci: This PR is to trigger periodic CI testing
github-actions[bot] 789bbbc
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3b10fb9
ci: This PR is to trigger periodic CI testing
github-actions[bot] 38e06db
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5197a61
ci: This PR is to trigger periodic CI testing
github-actions[bot] 69b1ddc
ci: This PR is to trigger periodic CI testing
github-actions[bot] 68f39f8
ci: This PR is to trigger periodic CI testing
github-actions[bot] c009b0e
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2481fe1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 522f3de
ci: This PR is to trigger periodic CI testing
github-actions[bot] 71523d5
ci: This PR is to trigger periodic CI testing
github-actions[bot] d356c72
ci: This PR is to trigger periodic CI testing
github-actions[bot] ee4fc28
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7396947
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8f2725b
ci: This PR is to trigger periodic CI testing
github-actions[bot] fd544fa
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9248612
ci: This PR is to trigger periodic CI testing
github-actions[bot] f52804f
ci: This PR is to trigger periodic CI testing
github-actions[bot] 05c95b5
ci: This PR is to trigger periodic CI testing
github-actions[bot] 25a5802
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2f64635
ci: This PR is to trigger periodic CI testing
github-actions[bot] f59316b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2c908ad
ci: This PR is to trigger periodic CI testing
github-actions[bot] cb04384
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0e33dd7
ci: This PR is to trigger periodic CI testing
github-actions[bot] 3bab9d1
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9d6afcc
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6c35194
ci: This PR is to trigger periodic CI testing
github-actions[bot] a04b150
ci: This PR is to trigger periodic CI testing
github-actions[bot] 132f9c7
ci: This PR is to trigger periodic CI testing
github-actions[bot] 02e8cd8
ci: This PR is to trigger periodic CI testing
github-actions[bot] 46368a9
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0939ef0
ci: This PR is to trigger periodic CI testing
github-actions[bot] e5c0a9b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 84a3144
ci: This PR is to trigger periodic CI testing
github-actions[bot] a2e44a7
ci: This PR is to trigger periodic CI testing
github-actions[bot] d118dde
ci: This PR is to trigger periodic CI testing
github-actions[bot] e320034
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2f4f7d2
ci: This PR is to trigger periodic CI testing
github-actions[bot] 7f5ee30
ci: This PR is to trigger periodic CI testing
github-actions[bot] c77df05
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1036f20
ci: This PR is to trigger periodic CI testing
github-actions[bot] 38d0536
ci: This PR is to trigger periodic CI testing
github-actions[bot] 63c5195
ci: This PR is to trigger periodic CI testing
github-actions[bot] 6e2bc07
ci: This PR is to trigger periodic CI testing
github-actions[bot] 21919eb
ci: This PR is to trigger periodic CI testing
github-actions[bot] 4b8c24e
ci: This PR is to trigger periodic CI testing
github-actions[bot] d88592b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 5c9fb46
ci: This PR is to trigger periodic CI testing
github-actions[bot] d187632
ci: This PR is to trigger periodic CI testing
github-actions[bot] ace293b
ci: This PR is to trigger periodic CI testing
github-actions[bot] 298dbb3
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2a5b8ea
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2e0a078
ci: This PR is to trigger periodic CI testing
github-actions[bot] a8302fe
ci: This PR is to trigger periodic CI testing
github-actions[bot] 2e78bdd
ci: This PR is to trigger periodic CI testing
github-actions[bot] 43560f8
ci: This PR is to trigger periodic CI testing
github-actions[bot] 4c1d718
ci: This PR is to trigger periodic CI testing
github-actions[bot] d7a8e4e
ci: This PR is to trigger periodic CI testing
github-actions[bot] b6b48ae
ci: This PR is to trigger periodic CI testing
github-actions[bot] 4bec6b0
ci: This PR is to trigger periodic CI testing
github-actions[bot] d66d666
ci: This PR is to trigger periodic CI testing
github-actions[bot] ee08582
ci: This PR is to trigger periodic CI testing
github-actions[bot] 844a706
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8a0c630
ci: This PR is to trigger periodic CI testing
github-actions[bot] 0fd8536
ci: This PR is to trigger periodic CI testing
github-actions[bot] 9a738f3
ci: This PR is to trigger periodic CI testing
github-actions[bot] a60cf03
ci: This PR is to trigger periodic CI testing
github-actions[bot] fcfd58a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8271d78
ci: This PR is to trigger periodic CI testing
github-actions[bot] 907aa13
ci: This PR is to trigger periodic CI testing
github-actions[bot] 1714d1a
ci: This PR is to trigger periodic CI testing
github-actions[bot] 47e3088
ci: This PR is to trigger periodic CI testing
github-actions[bot] 8fb0f83
ci: This PR is to trigger periodic CI testing
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # -*- coding: utf-8 -*- | ||
| # Copyright (C) 2023, Red Hat, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| from __future__ import absolute_import, division, print_function | ||
|
|
||
| __metaclass__ = type | ||
|
|
||
| DOCUMENTATION = """ | ||
| author: Rich Megginson | ||
| name: dump_packages | ||
| type: aggregate | ||
| short_description: dump arguments to package module | ||
| description: | ||
| - Dump arguments to package module to get list of packages. | ||
| - Used in conjunction with CI testing to get the packages used | ||
| - with all combinations of: distribution/version/role arguments | ||
| - Used to generate lists of packages for ostree image builds. | ||
| requirements: | ||
| - None | ||
| """ | ||
|
|
||
| from ansible.plugins.callback import CallbackBase # noqa: E402 | ||
|
|
||
|
|
||
| class CallbackModule(CallbackBase): | ||
| """ | ||
| Dump packages. | ||
| """ | ||
|
|
||
| CALLBACK_VERSION = 2.0 | ||
| CALLBACK_TYPE = "aggregate" | ||
| CALLBACK_NAME = "dump_packages" | ||
| # needed for 2.9 compatibility | ||
| CALLBACK_NEEDS_WHITELIST = False # wokeignore:rule=whitelist | ||
| CALLBACK_NEEDS_ENABLED = False | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| super(CallbackModule, self).__init__(*args, **kwargs) | ||
|
|
||
| def v2_runner_on_ok(self, result): | ||
| fields = result._task_fields | ||
| if ( | ||
| fields["action"] in ["package", "dnf", "yum"] | ||
| and fields["args"].get("state") != "absent" | ||
| ): | ||
| packages = set() | ||
| if "invocation" in result._result: | ||
| results = [result._result] | ||
| elif "results" in result._result and isinstance( | ||
| result._result["results"], list | ||
| ): | ||
| results = result._result["results"] | ||
| for item in results: | ||
| pkgs = item["invocation"]["module_args"]["name"] | ||
| if isinstance(pkgs, list): | ||
| for ii in pkgs: | ||
| packages.add(ii) | ||
| else: | ||
| packages.add(pkgs) | ||
| # tell python black that this line is ok | ||
| # fmt: off | ||
| self._display.display("lsrpackages: " + " ".join(sorted(list(packages)))) | ||
| # fmt: on | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
Copilot Autofix
AI 3 months ago
In general, to fix a “potentially uninitialized local variable” problem, either (1) initialize the variable to a safe default before any conditional assignments or (2) ensure all control-flow paths that reach its use have definitely assigned it (for example, by adding
elsecases or early returns).Here, the safest change without altering existing behavior is:
resultsto an empty list before theif/elifchain.resultsif it is non-empty; otherwise, simply skip the loop so noUnboundLocalErrorcan occur.This preserves current behavior when
resultsis defined as before, while making the code no-op (rather than crash) in the rare case that neither condition is met.Concretely in
tests/callback_plugins/dump_packages.py:CallbackModule.v2_runner_on_ok, addresults = []right afterpackages = set().for item in results:loop and subsequent package processing in anif results:guard so it only executes whenresultshas been set to something meaningful.No new imports or helper methods are required.