-
Notifications
You must be signed in to change notification settings - Fork 55
chore: change item delegate for taskmanager from DropArea to Item #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
将 taskmanager 组件的 item delegate 调整为 Item Log:
Reviewer's GuideRevert taskmanager item delegate from DropArea to Item and remove obsolete drag-and-drop logic now handled by launcherDndDropArea. Class diagram for removal of drag-and-drop logic from delegateclassDiagram
class DropArea {
onEntered(drag)
}
class Item {
// No onEntered handler
}
DropArea : - onEntered(drag)
Item : // onEntered removed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deepin pr auto review代码审查意见:
综上所述,建议在代码中添加必要的注释,并确保所有功能都按照预期工作。如果 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, BLumia The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
将 taskmanager 组件的 item delegate 调整为 Item
这里应该是引入
launcherDndDropArea之前的逻辑,由每个 item 自己处理被拖拽到图标上后的移动行为。现在应该没有实际再被使用了(拖拽事件会被launcherDndDropArea接受并处理,不会到 Item 自己的 DropArea 上),所以直接将其调整回 Item。Summary by Sourcery
Revert the TaskManager item delegate from DropArea to Item and remove its unused drag-and-drop code.
Chores: