Skip to content

chore: change item delegate for taskmanager from DropArea to Item #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BLumia merged 1 commit into from
Aug 6, 2025
Merged

chore: change item delegate for taskmanager from DropArea to Item #1214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions panels/dock/taskmanager/package/TaskManager.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ ContainmentItem {
onCountChanged: function() {
relayoutWorkaroundTimer.start()
}
delegate: DropArea {
delegate: Item {
id: delegateRoot
required property bool active
required property bool attention
Expand All @@ -89,7 +89,6 @@ ContainmentItem {
required property string iconName
required property string menus
required property list<string> windows
keys: ["text/x-dde-dock-dnd-appid"]
z: attention ? -1 : 0
property bool visibility: itemId !== taskmanager.Applet.desktopIdToAppId(launcherDndDropArea.launcherDndDesktopId)

Expand All @@ -113,11 +112,6 @@ ContainmentItem {
implicitWidth: useColumnLayout ? taskmanager.implicitWidth : visualModel.cellWidth
implicitHeight: useColumnLayout ? visualModel.cellWidth : taskmanager.implicitHeight

onEntered: function(drag) {
// TODO: this is actually unused, should change the delegateRoot type from DropArea to Item later.
visualModel.items.move(drag.source.DelegateModel.itemsIndex, delegateRoot.DelegateModel.itemsIndex)
}

property int visualIndex: DelegateModel.itemsIndex

AppItem {
Expand Down