Skip to content

Conversation

@wjyrich
Copy link
Contributor

@wjyrich wjyrich commented Sep 30, 2025

  1. Changed translation of "Fold" from "折叠" to "收起" in Simplified Chinese
  2. Changed translation of "Fold" from "折疊" to "收起" in Traditional Chinese (both Hong Kong and Taiwan variants)
  3. This change provides more accurate and user-friendly terminology for the fold/collapse action in notification center
  4. "收起" better conveys the action of hiding or minimizing content compared to "折叠" which implies physical folding

chore: 更新中文翻译中的折叠操作术语

  1. 将简体中文中"Fold"的翻译从"折叠"改为"收起"
  2. 将繁体中文中"Fold"的翻译从"折疊"改为"收起"(包括香港和台湾变体)
  3. 此更改提供了更准确和用户友好的通知中心折叠操作术语
  4. "收起"比"折叠"更能准确表达隐藏或最小化内容的操作意图

Pms: BUG-336147

Summary by Sourcery

Enhancements:

  • Update Chinese translation for the "Fold" action from "折叠"/"折疊" to "收起" in Simplified and Traditional variants

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the translation of the 'Fold' action in the notification center localization files for Simplified and Traditional Chinese variants with a more accurate and user-friendly term.

File-Level Changes

Change Details Files
Updated translation of 'Fold' to '收起' across Chinese locales
  • Simplified Chinese: 折叠 → 收起
  • Traditional Chinese (HK): 折疊 → 收起
  • Traditional Chinese (TW): 折疊 → 收起
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_CN.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_HK.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_TW.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这段diff显示的是对通知中心界面文本的翻译修改,主要涉及简体中文、繁体中文(香港)和繁体中文(台湾)三种语言版本。以下是详细的审查意见:

  1. 翻译一致性改进:
  • 原文 "Fold" 在所有三个语言版本中都被从当地语言的"折叠"(简体中文)、"折疊"(繁体中文香港/台湾)改为"收起"
  • 这个修改是合理的,因为"收起"更符合中文用户界面中常见的表达习惯,特别是在通知中心这类场景中
  1. 用户体验考虑:
  • "收起"比"折叠"更直观,更能表达将内容隐藏起来的动作意图
  • 这个修改保持了所有中文版本的一致性,避免了同一功能在不同语言版本中使用不同术语
  1. 建议改进:
  • 建议同时检查其他相关文本的翻译是否与"收起"保持一致
  • 考虑是否需要更新相关UI元素的提示文本或帮助文档,以确保整体用户体验的一致性
  1. 代码质量评估:
  • 这是一个简单的翻译更新,没有涉及代码逻辑或功能的修改
  • 修改符合国际化(i18n)的最佳实践,保持了翻译文件的结构和格式不变
  1. 安全性评估:
  • 此修改仅涉及文本内容,不会影响应用程序的安全性
  • 不会引入新的安全漏洞或风险

总体而言,这是一个合理的翻译更新,提高了用户体验和术语一致性。建议在发布前进行完整的UI测试,确保所有相关界面元素都能正确显示新的翻译文本。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1. Changed translation of "Fold" from "折叠" to "收起" in Simplified
Chinese
2. Changed translation of "Fold" from "折疊" to "收起" in Traditional
Chinese (both Hong Kong and Taiwan variants)
3. This change provides more accurate and user-friendly terminology for
the fold/collapse action in notification center
4. "收起" better conveys the action of hiding or minimizing content
compared to "折叠" which implies physical folding

chore: 更新中文翻译中的折叠操作术语

1. 将简体中文中"Fold"的翻译从"折叠"改为"收起"
2. 将繁体中文中"Fold"的翻译从"折疊"改为"收起"(包括香港和台湾变体)
3. 此更改提供了更准确和用户友好的通知中心折叠操作术语
4. "收起"比"折叠"更能准确表达隐藏或最小化内容的操作意图

Pms: BUG-336147
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR本身没问题,但是你不用提PR来着。

本地 tx push -t --language zh_CN,zh_HK,zh_TW 然后等待五分钟,等修改的翻译进入 #1283 就可以了。

@wjyrich wjyrich closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants