Skip to content

Conversation

@BLumia
Copy link
Member

@BLumia BLumia commented Nov 19, 2025

移除 de_DE 翻译资源,仅保留 de (不带地区变体后缀)的资源.

Summary by Sourcery

Chores:

  • Remove de_DE translation resource files across dock, notification, and OSD panels

移除 de_DE 翻译资源,仅保留 de (不带地区变体后缀)的资源.

Log:
@BLumia BLumia requested a review from wjyrich November 19, 2025 03:07
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 19, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR cleans up locale resources by deleting all de_DE-specific translation files for dock and notification components, ensuring only the generic 'de' locale remains.

File-Level Changes

Change Details Files
Removed dock component de_DE translation resources
  • Deleted de_DE translation for multitaskview
  • Deleted de_DE translation for showdesktop
  • Deleted de_DE translation for taskmanager
  • Deleted de_DE translation for dock core
  • Deleted de_DE translation for tray
panels/dock/multitaskview/translations/org.deepin.ds.dock.multitaskview_de_DE.ts
panels/dock/showdesktop/translations/org.deepin.ds.dock.showdesktop_de_DE.ts
panels/dock/taskmanager/translations/org.deepin.ds.dock.taskmanager_de_DE.ts
panels/dock/translations/org.deepin.ds.dock_de_DE.ts
panels/dock/tray/translations/org.deepin.ds.dock.tray_de_DE.ts
Removed notification component de_DE translation resources
  • Deleted de_DE translation for notification bubble
  • Deleted de_DE translation for notification center
  • Deleted de_DE translation for OSD default
  • Deleted de_DE translation for OSD display mode
panels/notification/bubble/translations/org.deepin.ds.notificationbubble_de_DE.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_de_DE.ts
panels/notification/osd/default/translations/org.deepin.ds.osd.default_de_DE.ts
panels/notification/osd/displaymode/translations/org.deepin.ds.osd.displaymode_de_DE.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这是一个删除德语翻译文件的diff。我来分析一下这个变更:

  1. 语法逻辑分析:
  • 所有被删除的文件都是合法的TS(Qt Translation Source)文件
  • XML结构完整,包含正确的DOCTYPE声明和TS版本信息
  • 文件内容遵循Qt翻译文件的格式规范
  1. 代码质量评估:
  • 翻译文件结构清晰,使用context对翻译内容进行分类
  • 源文本(source)和翻译文本(translation)配对完整
  • 使用了type="unfinished"标记未完成的翻译,这是一个好的实践
  1. 性能影响:
  • 删除这些翻译文件会减小程序的体积
  • 减少了运行时需要加载的翻译资源
  • 对于不需要德语环境的用户来说是性能优化
  1. 安全性考虑:
  • 删除翻译文件不会带来安全风险
  • 不会影响程序的核心功能
  • 只是移除了本地化支持

改进建议:

  1. 版本控制:
  • 建议在删除翻译文件前,确认是否真的不再需要德语支持
  • 如果是临时移除,建议在提交信息中说明原因和计划
  1. 文档更新:
  • 删除翻译文件后,需要更新相关的文档
  • 确保README或其他文档中不再提及德语支持
  1. 替代方案:
  • 如果是为了减小体积,可以考虑将翻译文件改为可选安装
  • 或者提供按需下载翻译文件的机制
  1. 测试建议:
  • 删除翻译文件后,应该测试程序在德语环境下的行为
  • 确保程序能够优雅地处理缺少翻译的情况
  1. 维护建议:
  • 建议建立一个翻译文件的管理策略
  • 明确哪些语言的翻译是必需的,哪些是可选的
  • 建立定期审查翻译文件完整性的机制

总的来说,这个变更本身是安全的,但需要谨慎考虑是否真的需要移除德语支持。如果确定要移除,建议做好相关的文档更新和测试工作。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, wjyrich

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit cefb56f into linuxdeepin:master Nov 19, 2025
8 of 12 checks passed
@BLumia BLumia deleted the remove-de_DE branch November 19, 2025 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants