feat(api): add past-meetings endpoints and frontend integration #78
Conversation
- Update MeetingService to accept meetingType parameter for filtering - Add PastMeetingController for handling past meeting requests - Create past-meetings routes for GET / and GET /:uid endpoints - Register past-meetings routes in server at /api/past-meetings - Add getPastMeetings() method to frontend meeting service - Update getPastMeetingsByProject() to use new past-meetings endpoint - Add getPastMeeting() method for individual past meeting retrieval Resolves LFXV2-450 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <[email protected]>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughAdds a past meetings feature across client and server: new client service methods and endpoint usage, a server controller with list/detail handlers for past meetings, routing for /api/past-meetings, and server MeetingService updates to accept a meeting type parameter enabling past meeting retrieval. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as Client UI
participant Api as API /api/past-meetings
participant Ctl as PastMeetingController
participant Svc as MeetingService (server)
Note over UI,Api: List past meetings
User->>UI: View Past Meetings
UI->>Api: GET /api/past-meetings?...
Api->>Ctl: route
Ctl->>Svc: getMeetings(req, query, 'past_meeting')
Svc-->>Ctl: Meeting[]
loop for each meeting
Ctl->>Svc: getMeetingRegistrants(uid)
Svc-->>Ctl: registrants
Ctl->>Ctl: compute counts
end
Ctl-->>Api: enriched Meeting[]
Api-->>UI: 200 JSON
UI-->>User: Render list
sequenceDiagram
autonumber
actor User
participant UI as Client UI
participant Api as API /api/past-meetings/:uid
participant Ctl as PastMeetingController
participant Svc as MeetingService (server)
Note over UI,Api: Past meeting details
User->>UI: Open Past Meeting
UI->>Api: GET /api/past-meetings/:uid
Api->>Ctl: route (+validate UID)
Ctl->>Svc: getMeetingById(req, uid, 'past_meeting')
Svc-->>Ctl: Meeting
opt registrant enrichment
Ctl->>Svc: getMeetingRegistrants(uid)
Svc-->>Ctl: registrants
Ctl->>Ctl: attach counts
end
Ctl-->>Api: Meeting (with counts)
Api-->>UI: 200 JSON
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Pre-merge checks (5 passed)✅ Passed checks (5 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Comment |
github-actions
bot
requested review from
andrest50,
audigregorie,
dealako and
mauriciozanettisalomao
There was a problem hiding this comment.
Pull Request Overview
This PR adds new API endpoints specifically for retrieving past meetings, providing a clean separation between current and past meeting functionality. The implementation reuses existing MeetingService logic by parameterizing the meeting type.
- Adds backend endpoints for past meetings at
/api/past-meetingsand/api/past-meetings/:uid - Updates MeetingService to accept configurable meeting types with 'past_meeting' support
- Implements frontend service methods to consume the new past meeting endpoints
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/lfx-pcc/src/server/services/meeting.service.ts | Adds meetingType parameter to support both regular and past meeting queries |
| apps/lfx-pcc/src/server/server.ts | Registers new past-meetings route handler |
| apps/lfx-pcc/src/server/routes/past-meetings.route.ts | Defines REST endpoints for past meeting operations |
| apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts | Implements controller logic for handling past meeting requests |
| apps/lfx-pcc/src/app/shared/services/meeting.service.ts | Adds frontend methods for consuming past meeting endpoints |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (5)
apps/lfx-pcc/src/app/shared/services/meeting.service.ts (1)
41-48: DRY: factor shared GET+catchError logicgetMeetings() and getPastMeetings() are identical aside from the path. A tiny helper reduces duplication.
+ private fetchMeetings(endpoint: string, params?: HttpParams): Observable<Meeting[]> { + return this.http.get<Meeting[]>(endpoint, { params }).pipe( + catchError((error) => { + console.error(`Failed to load from ${endpoint}:`, error); + return of([]); + }) + ); + } public getPastMeetings(params?: HttpParams): Observable<Meeting[]> { - return this.http.get<Meeting[]>('/api/past-meetings', { params }).pipe( - catchError((error) => { - console.error('Failed to load past meetings:', error); - return of([]); - }) - ); + return this.fetchMeetings('/api/past-meetings', params); }apps/lfx-pcc/src/server/services/meeting.service.ts (2)
41-46: Parametric meetingType is solid; guard the typeDefault preserves back-compat. Consider narrowing meetingType to known literals to prevent accidental misuse.
- public async getMeetings(req: Request, query: Record<string, any> = {}, meetingType: string = 'meeting'): Promise<Meeting[]> { + type MeetingResourceType = 'meeting' | 'past_meeting'; + public async getMeetings(req: Request, query: Record<string, any> = {}, meetingType: MeetingResourceType = 'meeting'): Promise<Meeting[]> { const params = { ...query, type: meetingType, };
64-67: Same here for getMeetingByIdApply the same literal-typing to keep the API tight.
- public async getMeetingById(req: Request, meetingUid: string, meetingType: string = 'meeting'): Promise<Meeting> { + public async getMeetingById(req: Request, meetingUid: string, meetingType: 'meeting' | 'past_meeting' = 'meeting'): Promise<Meeting> { const params = { type: meetingType, tags: `meeting_uid:${meetingUid}`, };apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts (2)
19-58: Optional: cap concurrency on registrant fetchesFor large result sets, N parallel calls can hammer the backend. Consider batching (e.g., size 8–16) or a small p-limit.
81-83: Avoid magic string for meeting typeDefine a constant (or reuse a shared enum/type) to prevent typos across handlers.
Example (apply near class top):
const PAST_MEETING_TYPE = 'past_meeting' as const; // ... const meeting = await this.meetingService.getMeetingById(req, uid, PAST_MEETING_TYPE);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
apps/lfx-pcc/src/app/shared/services/meeting.service.ts(3 hunks)apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts(1 hunks)apps/lfx-pcc/src/server/routes/past-meetings.route.ts(1 hunks)apps/lfx-pcc/src/server/server.ts(2 hunks)apps/lfx-pcc/src/server/services/meeting.service.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Prefer TypeScript interfaces over union types when modeling shapes and contracts
Files:
apps/lfx-pcc/src/server/routes/past-meetings.route.tsapps/lfx-pcc/src/server/services/meeting.service.tsapps/lfx-pcc/src/app/shared/services/meeting.service.tsapps/lfx-pcc/src/server/controllers/past-meeting.controller.tsapps/lfx-pcc/src/server/server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Do not nest ternary expressions
Files:
apps/lfx-pcc/src/server/routes/past-meetings.route.tsapps/lfx-pcc/src/server/services/meeting.service.tsapps/lfx-pcc/src/app/shared/services/meeting.service.tsapps/lfx-pcc/src/server/controllers/past-meeting.controller.tsapps/lfx-pcc/src/server/server.ts
apps/lfx-pcc/src/**/*.{ts,html}
📄 CodeRabbit inference engine (CLAUDE.md)
Use LFX wrapper components instead of importing PrimeNG components directly
Files:
apps/lfx-pcc/src/server/routes/past-meetings.route.tsapps/lfx-pcc/src/server/services/meeting.service.tsapps/lfx-pcc/src/app/shared/services/meeting.service.tsapps/lfx-pcc/src/server/controllers/past-meeting.controller.tsapps/lfx-pcc/src/server/server.ts
**/*.{ts,tsx,js,jsx,html,scss,css}
📄 CodeRabbit inference engine (CLAUDE.md)
Include required license headers on all source files
Files:
apps/lfx-pcc/src/server/routes/past-meetings.route.tsapps/lfx-pcc/src/server/services/meeting.service.tsapps/lfx-pcc/src/app/shared/services/meeting.service.tsapps/lfx-pcc/src/server/controllers/past-meeting.controller.tsapps/lfx-pcc/src/server/server.ts
apps/lfx-pcc/src/**/*.ts
📄 CodeRabbit inference engine (CLAUDE.md)
apps/lfx-pcc/src/**/*.ts: In the Angular app, use direct imports for standalone components (no barrel imports)
When defining types for PrimeNG usage, reference PrimeNG’s component interfaces
Files:
apps/lfx-pcc/src/server/routes/past-meetings.route.tsapps/lfx-pcc/src/server/services/meeting.service.tsapps/lfx-pcc/src/app/shared/services/meeting.service.tsapps/lfx-pcc/src/server/controllers/past-meeting.controller.tsapps/lfx-pcc/src/server/server.ts
🧠 Learnings (1)
📚 Learning: 2025-09-05T18:09:48.791Z
Learnt from: CR
PR: linuxfoundation/lfx-v2-ui#0
File: CLAUDE.md:0-0
Timestamp: 2025-09-05T18:09:48.791Z
Learning: Public routes include /meeting and /public/api; use M2M tokens for server-side API calls from public endpoints
Applied to files:
apps/lfx-pcc/src/server/server.ts
🧬 Code graph analysis (4)
apps/lfx-pcc/src/server/routes/past-meetings.route.ts (1)
apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts (1)
PastMeetingController(13-117)
apps/lfx-pcc/src/server/services/meeting.service.ts (1)
packages/shared/src/interfaces/meeting.interface.ts (1)
Meeting(75-142)
apps/lfx-pcc/src/app/shared/services/meeting.service.ts (1)
packages/shared/src/interfaces/meeting.interface.ts (1)
Meeting(75-142)
apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts (3)
apps/lfx-pcc/src/server/services/meeting.service.ts (1)
MeetingService(26-419)apps/lfx-pcc/src/server/helpers/logger.ts (2)
Logger(10-129)error(52-65)apps/lfx-pcc/src/server/helpers/validation.helper.ts (1)
validateUidParameter(30-49)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Code Quality Checks
🔇 Additional comments (7)
apps/lfx-pcc/src/app/shared/services/meeting.service.ts (3)
41-48: Good addition: client surface for past meetingsEndpoint, typing, and error handling mirror existing getMeetings(). Looks consistent.
86-86: Delegation to past endpoint is correctSwapping to getPastMeetings(params) keeps the project filter behavior intact.
99-107: Detail fetch mirrors existing meeting flowParity with getMeeting() (tap, error propagation) looks good.
apps/lfx-pcc/src/server/services/meeting.service.ts (1)
41-46: Confirm downstream supportspast_meetingtype
Verify the meeting-service API acceptstype=past_meetingfor both list and detail calls inpast-meeting.controller.ts(around lines 25 and 82).apps/lfx-pcc/src/server/routes/past-meetings.route.ts (1)
11-16: Router wiring looks correctHandlers are bound via lambdas, avoiding this-binding pitfalls.
apps/lfx-pcc/src/server/server.ts (1)
23-23: Mounted under protected /api with bearer extractionImport and mount order are correct: extractBearerToken precedes /api/past-meetings.
Also applies to: 206-207
apps/lfx-pcc/src/server/controllers/past-meeting.controller.ts (1)
91-104: Good: per-request registrant count failure is isolatedNested try/catch ensures detail route remains robust when registrant fetch fails.
✅ E2E Tests PassedBrowser: chromium All E2E tests passed successfully. Test Configuration
|
- Extract registrant counting logic into private helper method - Fix Promise.all error handling in getPastMeetings to prevent 500s - Default registrant counts to 0 when getMeetingRegistrants fails - Remove code duplication between getPastMeetings and getPastMeetingById - Ensure individual meeting failures don't break entire list requests Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Asitha de Silva <[email protected]>
🧹 Deployment RemovedThe deployment for PR #78 has been removed. |
Summary
This PR implements new API endpoints for retrieving past meetings and updates the frontend service to properly filter past meetings by project, addressing the TODO comment in
getPastMeetingsByProject().Changes Made
Backend Implementation
meetingTypeparameter ingetMeetings()andgetMeetingById()methodsGET /api/past-meetings- Lists all past meetingsGET /api/past-meetings/:uid- Gets specific past meeting by UID/api/past-meetingsFrontend Implementation
getPastMeetings()method for general past meeting queriesgetPastMeetingsByProject()to use new past-meetings endpoint (removed TODO)getPastMeeting()method for individual past meeting retrievalTechnical Details
Test Plan
Breaking Changes
None - this is a purely additive change.
Linked Issues
Resolves LFXV2-450
Generated with Claude Code