meson: fix some implicit ordering dependencies on generated headers #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given sufficiently high or simply random parallelism, it was possible to build various source files that included this generated header, without having coincidentally built the header previously. It then failed to compile, since there was no actual guarantee the header would come first. Add explicit header-only dependencies by adding the header as additional sources to targets that draw it in. Fixes: ``` * QA Notice: missing ninja dependencies in /var/tmp/portage/x11-wm/muffin-6.4.1/work/muffin-6.4.1-build: [...] * Processed 517 nodes. * Error: There are 249 missing dependency paths. * 249 targets had depfile dependencies on 1 distinct generated inputs (from 1 rules) without a non-depfile dep path to the generator. * There might be build flakiness if any of the targets listed above are built alone, or not late enough, in a clean output directory. ``` Signed-off-by: Eli Schwartz <[email protected]>
SunPodder
pushed a commit
to SunPodder/muffin
that referenced
this pull request
Apr 13, 2025
…inuxmint#716) Given sufficiently high or simply random parallelism, it was possible to build various source files that included this generated header, without having coincidentally built the header previously. It then failed to compile, since there was no actual guarantee the header would come first. Add explicit header-only dependencies by adding the header as additional sources to targets that draw it in. Fixes: ``` * QA Notice: missing ninja dependencies in /var/tmp/portage/x11-wm/muffin-6.4.1/work/muffin-6.4.1-build: [...] * Processed 517 nodes. * Error: There are 249 missing dependency paths. * 249 targets had depfile dependencies on 1 distinct generated inputs (from 1 rules) without a non-depfile dep path to the generator. * There might be build flakiness if any of the targets listed above are built alone, or not late enough, in a clean output directory. ``` Signed-off-by: Eli Schwartz <[email protected]>
Sunderland93
pushed a commit
to Sunderland93/muffin
that referenced
this pull request
Aug 14, 2025
…inuxmint#716) Given sufficiently high or simply random parallelism, it was possible to build various source files that included this generated header, without having coincidentally built the header previously. It then failed to compile, since there was no actual guarantee the header would come first. Add explicit header-only dependencies by adding the header as additional sources to targets that draw it in. Fixes: ``` * QA Notice: missing ninja dependencies in /var/tmp/portage/x11-wm/muffin-6.4.1/work/muffin-6.4.1-build: [...] * Processed 517 nodes. * Error: There are 249 missing dependency paths. * 249 targets had depfile dependencies on 1 distinct generated inputs (from 1 rules) without a non-depfile dep path to the generator. * There might be build flakiness if any of the targets listed above are built alone, or not late enough, in a clean output directory. ``` Signed-off-by: Eli Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given sufficiently high or simply random parallelism, it was possible to build various source files that included this generated header, without having coincidentally built the header previously. It then failed to compile, since there was no actual guarantee the header would come first. Add explicit header-only dependencies by adding the header as additional sources to targets that draw it in.
Fixes: