Add missing type exports required by @livekit/components-core#1815
Merged
Add missing type exports required by @livekit/components-core#1815
@livekit/components-core#1815Conversation
🦋 Changeset detectedLatest commit: ec85d45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
lukasIO
approved these changes
Feb 19, 2026
Merged
1egoman
added a commit
to livekit/components-js
that referenced
this pull request
Feb 19, 2026
The ts-ignore comments above (most) don't get copied into the resulting built version of the code so these issues still get raised by downstream users who rely on using the typing files in `dist/`. Relevant upstream change this relies on: livekit/client-sdk-js#1815
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a few places,
@livekit/components-coreimports unexported types from an import path prefixed withlivekit-client/dist/.... However, per the livekit-client package.json, there are only two supported package "exports", so depending on how strict downstream tools are, this may result in build errors like the below:I did an inventory and it looks like in all of the components-js repo, there are four types that are being imported this way:
TextStreamInfoPublicationEventCallbacksRoomEventCallbacks(Note this is already being exported from thelivekit-clientpackage, so these imports can be fixed without upstream modifications)ParticipantEventCallbacksSo, this pull request adds the remaining three as exports in preparation for rewriting the imports in
@livekit/components-core.