Refactor codec interface, allow using codecs without RTP#51
Merged
Conversation
This reverts commit ea94ab3.
alexlivekit
approved these changes
Apr 7, 2026
biglittlebigben
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reverts a previous PR that obliterated type-safety in the media pipeline to be able to use codecs directly (without RTP streams).
Instead, move codecs out of the RTP package and introduce an intermediate interface. This allows using codecs directly with binary streams. From Go's perspective, there's also a non-generic audio codec interface now, so any codec can be used directly without type assertions (which was the reasoning for the previous PR).
Old path still works as well and is simpler now. SIP will require a tiny update to use the new interface.