Open
Conversation
dennwc
force-pushed
the
new-codec-interface
branch
2 times, most recently
from
8409020 to
9c3302c
Compare
alexlivekit
reviewed
Apr 7, 2026
Comment on lines
+47
to
+54
| type nopCloser struct { | ||
| *SilenceSuppressionTester | ||
| } | ||
|
|
||
| func (s nopCloser) Close() error { | ||
| return nil | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Doesn't SilenceSuppressionTester already have func (s *SilenceSuppressionTester) Close() error?
Contributor
Author
There was a problem hiding this comment.
It does, but the signature is slightly different. The HandlerCloser has Close(), while Writer was Close() error. This is why it needs a tiny adapter to act like both at the same time.
dennwc
force-pushed
the
new-codec-interface
branch
from
9c3302c to
cc5537a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires livekit/media-sdk#51