-
Notifications
You must be signed in to change notification settings - Fork 83
Check the CONTAINER_TOOL value and use it in the e2e test script #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hannah DeFazio <[email protected]>
Signed-off-by: Hannah DeFazio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @nirrozenbaum
Please rebase this PR |
@shmuelk @nirrozenbaum PTAL |
@hdefazio Please rebase your branch |
@shmuelk Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdefazio - thanks! please see question regarding L300 (not a blocker for merging).
/lgtm
/approve
@if [ -z "$(CONTAINER_TOOL)" ]; then \ | ||
echo "❌ Error: No container tool detected. Please install docker or podman."; \ | ||
exit 1; \ | ||
elif ! command -v $(CONTAINER_TOOL) >/dev/null 2>&1; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Since L40 sets CONTAINER_TOOL using command -v ...
, can the check in L300 ever fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that's fair - this was the original check for the make target so I didn't want to remove it. Without this, the check basically just becomes "Is CONTAINER_TOOL an empty string"?
Description
How Has This Been Tested?
(this is correct for my system)
Other cases:
Manually set CONTAINER_TOOL := ""
Manually set CONTAINER_TOOL := "docker"
(this is correct for my system)
Merge criteria:
Summary by CodeRabbit
New Features
Improvements
Tests