Removed extraneous yout copy#814
Open
drreynolds wants to merge 34 commits intofeature/stageprocessingfrom
Open
Removed extraneous yout copy#814drreynolds wants to merge 34 commits intofeature/stageprocessingfrom
drreynolds wants to merge 34 commits intofeature/stageprocessingfrom
Conversation
…aliases yout, and just prior to this copy ycur was copied into yn)
drreynolds
requested review from
balos1,
cswoodward and
gardner48
as code owners
Co-authored-by: Steven Roberts <roberts115@llnl.gov>
Steven-Roberts
approved these changes
Jan 16, 2026
Collaborator
Author
|
This is the second in a sequence of PRs for ARKODE to support our FES collaborators. Please review this one after #813. When the stack is complete, we'll do a final PR into |
Collaborator
Author
|
This PR should be ready to review -- all CI issues resulting from the new release have been resolved. |
balos1
approved these changes
Feb 4, 2026
Member
|
Does this need to be merged after #813? |
Collaborator
Author
gardner48
requested changes
Feb 7, 2026
… clobbered when merging
…rmining if a root was passed (they still fill ycur in the case of roots)
Collaborator
Author
|
I have addressed all PR comments. I couldn't mark some as "resolved" because they were adjacent to other code modifications, and thus GitHub marked them as "outdated." Once this passes the CI then I think it should be good to merge into the staging branch. |
gardner48
requested changes
Mar 3, 2026
Member
gardner48
left a comment
gardner48
left a comment
There was a problem hiding this comment.
Two minor edits, otherwise this looks good
Co-authored-by: David Gardner <gardner48@llnl.gov>
gardner48
approved these changes
Mar 3, 2026
gardner48
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed extraneous copy of
ynintoyoutin ONE_STEP mode for ARKODE (sinceycuraliasesyout, and just prior to this copyycurwas copied intoyn).