Skip to content

Conversation

@fzi-hielscher
Copy link
Contributor

@fzi-hielscher fzi-hielscher commented Sep 26, 2025

As an alternative to #8926, add the MSVC /utf-8 flag only to CMake targets which include the slang headers.

I am not particularly confident that mixing translation units with and without this flag is not going to cause trouble. But for the moment it appears to be working in the UBTI CI build.

Closes #8927.

@fzi-hielscher fzi-hielscher marked this pull request as ready for review September 26, 2025 14:18
@seldridge
Copy link
Member

This looks great. I'm giving it a run on the UBTI static build here: https://github.com/llvm/circt/actions/runs/18042294978/job/51344181670 I'd like to use this for this release (adding circt-verilog as a published tool).

@seldridge
Copy link
Member

That UBTI static shouldn't be affected by this... UBTI closer to a Windows release is here: https://github.com/llvm/circt/actions/runs/18043093695/job/51347037515 I realize that this should be fine given that this is running in the pre-merge Windows job. I just want to make sure the release goes out fine.

@fzi-hielscher
Copy link
Contributor Author

I'm a bit lost regarding what workflow ends up where. But if we can get circt-verilog in the next release, that would be really awesome. Thanks!

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for figuring this out. LGTM

This unblocks building circt-verilog in the release. 💯

@seldridge seldridge merged commit a2c4f38 into main Sep 26, 2025
14 of 15 checks passed
@seldridge seldridge deleted the dev/fzi-hielscher/slang-windows-test-new branch September 26, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants